data-curator icon indicating copy to clipboard operation
data-curator copied to clipboard

Make on-screen Product Name "Data Curator"

Open Stephen-Gates opened this issue 7 years ago • 5 comments

Replacing PR #120

Expected Behaviour (for problems)

Application name appears on-screen as "Data Curator"

Current Behaviour

Some UI elements show "DataCurator" a set in package.json

screenshot 2017-10-04 11 23 45 screenshot 2017-10-04 11 23 34

Your Environment

  • Data Curator version 0.3.4
  • Operating System macOS High Sierra 10.13

Stephen-Gates avatar Oct 04 '17 01:10 Stephen-Gates

Still present in 0.5.4

Stephen-Gates avatar Nov 29 '17 21:11 Stephen-Gates

Hi @Stephen-Gates It's been a while, but originally I think there might have been an issue with downloading a url with spaces from github - not sure, so I'll update productName to have space for mac and windows build and then, I'll have to do an minor version build first to test and if it doesn't work look at adding a shell script step that changes the name of the zip package (not the internal application) to allow for download.

ghost avatar Mar 14 '18 01:03 ghost

Hi @Stephen-Gates Despite, the build failing, the artifacts were published -so will check shortly. It think the build reported a fail as the change in archive name (removing spaces -while trying to preserve the new product with spaces internally) is different to the blockmap files (possibly used like a checksum) - will update these files too for next build as see if it helps.

ghost avatar Mar 15 '18 00:03 ghost

Nope :( Intermediary step does not seem to have worked, will have to try a different approach.

ghost avatar Mar 15 '18 00:03 ghost

Problem remains in 0.17.0

Stephen-Gates avatar May 27 '18 03:05 Stephen-Gates