qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Update Changelog

Open sledgehammer999 opened this issue 1 year ago • 3 comments

Please review the changelog entries for v5 RC1. I have left the commit hash to ease review.

Also I have taken into account the stuff from PR #20918

PS: This is just for review. After it is approved I'll push it manually, deleting the hashes.

sledgehammer999 avatar Jun 25 '24 00:06 sledgehammer999

https://github.com/qbittorrent/qBittorrent/pull/20918/commits/c36100fa8532e267d1da122a640faedc278b2d7b should be mentioned as WINDOWS: Don't access "Favorites" folder unexpectedly.

glassez avatar Jun 25 '24 07:06 glassez

With the 5.1.0 milestone going up, can we expect a 5.0.0 RC1 release today?

Pentaphon avatar Jun 30 '24 10:06 Pentaphon

With the 5.1.0 milestone going up, can we expect a 5.0.0 RC1 release today?

Lol. I would say in the next month (according to optimistic forecasts). I expected v5.0 would be finally released at the beginning of the year.

glassez avatar Jun 30 '24 10:06 glassez

The website says to check back for RC 5.0, that is getting on almost a month ago now.

Ryrynz avatar Jul 20 '24 01:07 Ryrynz

The website says to check back for RC 5.0, that is getting on almost a month ago now.

No definitive date/timeline should've been given imo, should've stated something like "check periodically for an upcoming 5.0 RC" or just release it when it was ready.

If anyone wishes to actually test what's coming/fixed/broken - try our CI master builds at your own risk/not meant for everyday environmental purposes.

xavier2k6 avatar Jul 20 '24 10:07 xavier2k6

No definitive date/timeline should've been given imo, should've stated something like "check periodically for an upcoming 5.0 RC" or just release it when it was ready.

Not to sound overly critical but the naming is crazy, going from a Beta 1 straight to RC1 then with a potentially six month wait (according to the post above) for release is pretty wild. Release Candidates are essentially "ready" to be released and give the impression as such.. along with specifying potential timeframes for release isn't a good look for the news section.

Ryrynz avatar Jul 20 '24 23:07 Ryrynz

Not to sound overly critical but the naming is crazy, going from a Beta 1 straight to RC1 then with a potentially six month wait (according to the post above) for release is pretty wild.

Plus there's already a 5.1 milestone before 5.0 is even out of beta...I don't get the delay on 5.0 yet a rush to 5.1 at the same time.

Pentaphon avatar Jul 21 '24 23:07 Pentaphon

Plus there's already a 5.1 milestone before 5.0 is even out of beta...I don't get the delay on 5.0 yet a rush to 5.1 at the same time.

There is no such relationship between these milestones, as you probably think. v5.0RC is ready to be released for some time but it is delayed because of reasons of @sledgehammer999. At the same time the development process is not stopped and there are new changes that aren't suitable to be merged into v5.0 branch at this stage of it (beta/RC) so they are targeted for v5.1.

glassez avatar Jul 22 '24 06:07 glassez

@Ryrynz @Pentaphon Any further discussions about 5.0 release can be done in below topic:

  • #20881

xavier2k6 avatar Jul 22 '24 10:07 xavier2k6

Please review the new commits

sledgehammer999 avatar Aug 17 '24 20:08 sledgehammer999

(Sorry I'm late) would it be feasible to add a single entry mentioning the code cleanups done by contributors? While "code cleanups" is not an exciting feature it improves the codebase and reduce technical debt. It could be like: OTHER: Internal refactors, code clean ups (<contributor_name>)

Chocobo1 avatar Aug 18 '24 08:08 Chocobo1

(Sorry I'm late) would it be feasible to add a single entry mentioning the code cleanups done by contributors? While "code cleanups" is not an exciting feature it improves the codebase and reduce technical debt. It could be like: OTHER: Internal refactors, code clean ups (<contributor_name>)

I was thinking of mentioning that as the text in the News entry in the website instead (the general section above the changelogs), when the final release is made.

sledgehammer999 avatar Aug 19 '24 19:08 sledgehammer999