qBittorrent
qBittorrent copied to clipboard
qbittorrent
GHA CI: don't use hardcoded path
Note that the recent CI failure on macOS is unrelated to this change. In short the homebrew made a mistake when packaging openssl 3.3.0 and they fixed it afterwards. The macOS image cached the faulty openssl 3.3.0 package before the fix was released and now we are stuck with it. AFAIK macOS image will be updated weekly so the issue will resolve itself eventually (when macOS image updates to the latest openssl package).
the issue will resolve itself eventually (when macOS image updates to the latest openssl package).
Shouldn't we wait for that before we merge this PR?
Shouldn't we wait for that before we merge this PR?
OK I'll trigger rebuild of macOS CI jobs when the new image is released. And merge this when it build successfully.
macos-14/macos-latest labels now default to using arm runner images, 12/13 are still intel based.
the issue will resolve itself eventually (when macOS image updates to the latest openssl package).
Shouldn't we wait for that before we merge this PR?
Someone reported it: https://github.com/actions/runner-images/issues/9755
Is there a reason we keep this at 17? master has changed to 20
https://github.com/qbittorrent/qBittorrent/blob/d3315f7cc7f31b1578cf72f07b175a80c204dac9/.github/workflows/ci_macos.yaml#L94
New C++ projects you create in Xcode use C++20 language dialect by default
macos-14/macos-latest uses Xcode 15.0.1 (default)
Is there a reason we keep this at 17? master has changed to 20
I did attempt to change it but it resulted in build errors. I already submitted patches to libtorrent (and merged) but that branch hasn't seen a new release.
New macOS image deployed with openssl/homebrew package fix, re-ran CI on all 4x macOS builds which have passed.