Fix login script for firefox reload

[JayRet]

Fixes reload bug in login.js for webgui on librewolf by adding location.assign(location); before location.reload(true);. left the latter for when location.assign(location); fails. Closes #20441.

[sledgehammer999]

I think Location.replace() is more appropriate here. However, wait for other web devs to weigh in on this. I am not a very good web dev.

[JayRet]

Yep, I think you're right. I'll commit with location.replace instead.

[JayRet]

I realized that i missed to add { } because of the multiline if and that's probably why the checks are failing. I'll commit with brackets.

[sledgehammer999]

@JayRet if you know how, please "fixup" the commits into one. Something like this:

git rebase -i HEAD~4
// choose 'fixup' in the opened file in your text editor
// save file and exit
git push --force origin fix-firefox-login
//adjust 'origin' the correct remote name if you have changed it

[Chocobo1]

@JayRet Thank you!

[Chocobo1]

@sledgehammer999 I've just squash and merged it. IMO it is fine to merge it this way and isn't worth to keep waiting.

[sledgehammer999]

@Chocobo1 is it ok if this is backported?

[Chocobo1]

@Chocobo1 is it ok if this is backported?

The new behavior might depends on each browser implementation so I'm not sure. And I'm not eager to present it to users.