qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

GHA CI: Use Qt 6.6.2 on Windows and macOS

Open xavier2k6 opened this issue 4 months ago • 6 comments

Note1: (Bumped along the way)

  • Bumped pre-commit/action to 3.0.1 Addresses: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

  • Bumped pre-commit hook (typos) rev: v1.18.2

xavier2k6 avatar Feb 16 '24 17:02 xavier2k6

Note 2: Linux/Coverity CI - As of Qt 6.6 will fail with ERROR: Could not find dependency: libmimerapi.so (All SQL plugins/drivers seem to be being built)

Note 3: Windows CI - As of Qt 6.7 - qwindowsvistastyle plugin renamed to qmodernwindowsstyle Potential fix/workaround: copy "${{ env.Qt6_DIR }}/plugins/styles/qwindowsvistastyle.dll" -> copy "${{ env.Qt6_DIR }}/plugins/styles/q*style.dll"

Note 4: Latest pandoc detects/suggests changes to files contained in doc folder. logs_10260.zip

xavier2k6 avatar Feb 16 '24 17:02 xavier2k6

As of Qt 6.7

I don't care until it is released.

glassez avatar Feb 16 '24 17:02 glassez

Potential fix/workaround: copy "${{ env.Qt6_DIR }}/plugins/styles/qwindowsvistastyle.dll" -> copy "${{ env.Qt6_DIR }}/plugins/styles/q*style.dll"

👍 if it doesn't copy extra dlls. On a second thought, there will be no confusion of which file was copied if the filename is listed explicitly (i.e. no wildcard used).

Latest pandoc detects/suggests changes to files contained in doc folder.

You can commit them if you want.

Chocobo1 avatar Feb 16 '24 17:02 Chocobo1

Bumped Windows/macOS Qt version to 6.6.2

I tested Windows binary and there is a (Qt?) bug. Start qbt and open Options dialog and close it. The main window is now unresponsive. This occurred to me on linux too (archlinux recently updated Qt to 6.6.2). I mean maybe pick another Qt version for now.

Chocobo1 avatar Feb 18 '24 05:02 Chocobo1

Bumped Windows/macOS Qt version to 6.6.2

I tested Windows binary and there is a (Qt?) bug. Start qbt and open Options dialog and close it. The main window is now unresponsive. This occurred to me on linux too (archlinux recently updated Qt to 6.6.2). I mean maybe pick another Qt version for now.

Qt 6.6.2 & Qt 6.7.0 Beta 3 exhibit this problem (<= Qt 6.6.1 does not) - will change to Qt 6.6.1 (although Qt 6.6.3 is due at end of month & may bring a fix?)


In relation to Qt style naming change, I think the wildcard of *style.dll is sufficient as it copies only 1 dll file & a comment can be added like:

          mkdir upload/qBittorrent/plugins/styles
          # We use "*style.dll" here due to Qt naming change "qwindowsvistastyle.dll" is used for (<= Qt 6.6.x) & "qmodernwindowsstyle.dll" is used for (>= Qt 6.7.x)
          copy "${{ env.Qt6_DIR }}/plugins/styles/*style.dll" upload/qBittorrent/plugins/styles

This naming change is really only a small issue for those of us who want to test with multiple versions.....release/beta etc.

xavier2k6 avatar Feb 18 '24 12:02 xavier2k6

I tested Windows binary and there is a (Qt?) bug. Start qbt and open Options dialog and close it. The main window is now unresponsive. This occurred to me on linux too (archlinux recently updated Qt to 6.6.2).

IIRC, the problem is the deletion of QFileSystemModel instances used inside FileSystemPathEdit.

glassez avatar Feb 18 '24 14:02 glassez

I've used Qt 6.6.1 instead & style naming issue can be handled at a later stage, pandoc changes can be done in different PR.

xavier2k6 avatar Feb 21 '24 16:02 xavier2k6

I've used Qt 6.6.1 instead

Qt 6.6.1 has at least one annoying regression: https://bugreports.qt.io/browse/QTBUG-120049

glassez avatar Feb 21 '24 17:02 glassez

Qt 6.6.1 has at least one annoying regression

looks like any changes here need to be put on hold for now.

xavier2k6 avatar Feb 22 '24 09:02 xavier2k6

I tested Windows binary and there is a (Qt?) bug. Start qbt and open Options dialog and close it. The main window is now unresponsive. This occurred to me on linux too (archlinux recently updated Qt to 6.6.2).

IIRC, the problem is the deletion of QFileSystemModel instances used inside FileSystemPathEdit.

QTBUG-122719

glassez avatar Feb 25 '24 15:02 glassez

QTBUG-122719

@glassez reproducible sample required...

xavier2k6 avatar Mar 11 '24 10:03 xavier2k6

QTBUG-122719

@glassez reproducible sample required...

Done.

glassez avatar Mar 12 '24 11:03 glassez

Qt 6.6.3 Released / Release Notes

  • Qt 6.6.3 is last of Qt 6.6 Series

Qt 6.7.0 Released / Release Notes


Neither exhibit issue from https://github.com/qbittorrent/qBittorrent/pull/20431#issuecomment-1950964097

Unsure if other regressions have been resolved too.

xavier2k6 avatar Apr 05 '24 11:04 xavier2k6

I'll address typos/pre-commit in another PR due to false positives in testing latest rev.

xavier2k6 avatar Apr 20 '24 10:04 xavier2k6

This issue is still present in 6.7.0 https://github.com/qbittorrent/qBittorrent/issues/19044

stalkerok avatar Apr 21 '24 08:04 stalkerok

@xavier2k6 Thank you!

glassez avatar Apr 22 '24 12:04 glassez