qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Published 20 hours ago • verified publisher icon qbittorrent

Add four new icons to the View menu

Open buckmelanoma opened this issue 1 year ago • 4 comments

This pull request adds four new icons to actions in the View menu that are currently missing icons:

  • RSS Reader
  • Filters Sidebar
  • Speed in Title Bar
  • Search Engine

Before: image

After: image

buckmelanoma avatar Feb 11 '24 16:02 buckmelanoma

LGTM, untested

luzpaz avatar Feb 11 '24 17:02 luzpaz

From the screens provided by @xavier2k6 it is clear that the checkboxes are replaced by the icons (when available by the icon theme). IMO, a checkbox provides a much better indication to the user that the item is toggleable and the state of the toggle. On that grounds, I propose to not merge this PR.

sledgehammer999 avatar Mar 03 '24 02:03 sledgehammer999

On that grounds, I propose to not merge this PR.

I wouldn't approve it anyway. https://github.com/qbittorrent/qBittorrent/pull/20406#discussion_r1491310123

glassez avatar Mar 03 '24 05:03 glassez

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

github-actions[bot] avatar May 03 '24 00:05 github-actions[bot]

This PR was closed because it has been stalled for some time with no activity.

github-actions[bot] avatar May 10 '24 00:05 github-actions[bot]