qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Fix some file renaming woes (probably)

Open calumapplepie opened this issue 1 year ago • 7 comments

Hullo, new contributer, wanted to avoid others losing data the way I just did!

I added a few new checks that, to my knowlege, will prevent users from renaming files on top of files that exist. While this can be useful for reseeding, it causes instant data loss if qbittorrent has downloaded any part of the existing file.

I also do some cleanup on messages and exists() function.

Reject the PR if you'd prefer to move the functionality to a different place, but I had the itch to hack something up to fix this, and I couldn't resist.

Probably closes a few issues, but I wasn't sure which, and I should get back to final projects.

calumapplepie avatar Dec 16 '23 04:12 calumapplepie

Thanks! Can you look at https://github.com/qbittorrent/qBittorrent/issues?q=is%3Aopen+is%3Aissue+label%3A%22Data+loss%22 and see which tickets this PR addresses ?

luzpaz avatar Dec 16 '23 09:12 luzpaz

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

github-actions[bot] avatar Feb 15 '24 00:02 github-actions[bot]

Not stale, I just don’t have the bandwidth to hunt through issues in an unfamiliar repo.

calumapplepie avatar Feb 15 '24 16:02 calumapplepie

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

github-actions[bot] avatar Apr 16 '24 00:04 github-actions[bot]

Not stale

calumapplepie avatar Apr 16 '24 10:04 calumapplepie

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

github-actions[bot] avatar Jun 20 '24 00:06 github-actions[bot]

Still not stale <3

calumapplepie avatar Jun 20 '24 01:06 calumapplepie