qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

The text box is not focused in the Rename dialog (QTBUG-120049)

Open jinliu opened this issue 1 year ago • 7 comments

qBittorrent & operating system versions

qBittorrent: 4.6.2 x64 Operating system: Linux Qt: 6.6.1 Libtorrent: 2.0.9.0 Boost: 1.83.0 OpenSSL: 3.1.4 zlib: 1.3

What is the problem?

When pressing F2 to rename a torrent, in previous versions, the textbox is focused in the dialog. But in the current version, the OK button is focused instead, requiring a mouse click to edit the text.

Steps to reproduce

  1. Select a torrent.
  2. Press F2
  3. Focus is on the OK button.

Additional context

No response

Log(s) & preferences file(s)

No response

jinliu avatar Dec 02 '23 03:12 jinliu

Works correctly on Windows. @qbittorrent/bug-handlers, could someone test it on Linux?

glassez avatar Dec 02 '23 11:12 glassez

Some more info:

  1. I'm running Archlinux, KDE Plasma 6 beta, Wayland.
  2. The problem happens in both X11 and Wayland (qbittorrent -platform xcb/wayland)
  3. Tags-Add has the same problem, so probably it's in the AutoExpandableDialog they both use.
  4. Seems it doesn't set focus explicitly, so perhaps it's QT who changed which widget gets focused by default: https://github.com/qbittorrent/qBittorrent/blob/4ba8eaf4b496cab2154b0d212b57a93cab4ad9ef/src/gui/autoexpandabledialog.cpp#L61

jinliu avatar Dec 02 '23 12:12 jinliu

Luckily i tested it before i updated my system. Qt 6.6.0: Can't reproduce, Qt 6.6.1: Can reproduce.

thalieht avatar Dec 02 '23 19:12 thalieht

Can't reproduce on

Manjaro 23.0.2 v5.0.0alpha1 (64-bit) Qt: 6.5.2 Libtorrent: 2.0.9.0 Boost: 1.76.0 OpenSSL: 3.0.2 zlib: 1.3

luzpaz avatar Dec 03 '23 00:12 luzpaz

Can reproduce

Archlinux:

pkg ver
qbittorrent 4.6.2-2
qt6-base 6.6.1-1
xorg-server 21.1.9-1

It's annoying as ****, I always press F2, CTRL-C to copy the name and paste it in the search tab to search for the next episode in a series.

This small change in behaviour is strange as one would expect when renaming a torrent, the focus would be on the text...

ManuLinares avatar Dec 07 '23 22:12 ManuLinares

Qt 6.6.0: Can't reproduce, Qt 6.6.1: Can reproduce.

Could you test #20103? Unfortunately I'm still under v6.6.0.

glassez avatar Dec 08 '23 07:12 glassez

QTBUG-120049

glassez avatar Dec 12 '23 18:12 glassez

Closing - Resolved in newer Qt Version(s)

xavier2k6 avatar Aug 15 '24 15:08 xavier2k6