qBittorrent
qBittorrent copied to clipboard
WebUI: Add log viewer
- show / hide the
Logstab:

- show logs

- filter logs by level


- filter logs by keywords

Works great 👍
the CI complains about the style.
I ran npm run format and pushed the change
PTAL
@brvphoenix thank you for the detailed review I will push the changes late in this week, mostly in the weekend.
right click context menu has been added according @brvphoenix 's suggestion:

@ttys3 I have improved your implementation by adding some extra features, fixing some found bugs and cleanup the code. After some testing, I will squash all the commits and push it to my forks. The commit will author with you and co-author with me.
Because there are so many revisions, I can't add all the comments here. I don't know whether you mind I make another pull request to replace this one. Or you can modify your pr based on my commit.
@brvphoenix as long as it is good for the project, I am OK with that. you can make another PR.
@brvphoenix as long as it is good for the project, I am OK with that. you can make another PR.
Thank you. You can test it with my fork. I add the baned ip log and add selectlist implementation from 3rd-part (MIT LICENSE). It works as I expect now. https://github.com/brvphoenix/qBittorrent/commits/new_log_view
LGTM
one NIT:
my bad, the var name should refined: urls => messages
in
new ClipboardJS('.copyLogDataToClipboard', {
text: function() {
let urls = [];
currentTable.selectedRowsIds().each(function(rowId) {
urls.push(currentTable.rows.get(rowId).full_data[(currentSelectedTab === "main") ? 'message' : 'ip']);
});
return urls.join('\n');
}
});
@brvphoenix
as discussed https://github.com/qbittorrent/qBittorrent/pull/18189#issuecomment-1359452845
a new PR will replace this one, see : https://github.com/qbittorrent/qBittorrent/pull/18290