qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Qbtheme stopped working after 4.5.0

Open AdaBallard opened this issue 2 years ago • 12 comments

qBittorrent & operating system versions

Windows 8.1 x64 qbittorrent 4.5.0

What is the problem?

Qbtheme I've been successfuly using for 2 years (the link is below) stopped working after 4.5.0 and just shows the default interface when enabled.

https://github.com/FoxInFlame/legacy-qBittorrent

Is this possible to fix?

Steps to reproduce

  1. Download "legacy-qBittorrent.qbtheme" from https://github.com/FoxInFlame/legacy-qBittorrent/releases/tag/v1.0
  2. Set the path to it into "Behavior - use custom ui theme - ui theme file"
  3. Restart qbittorrent 4.5.0
  4. See the default user interface (instead the one from .qbtheme file)

Additional context

No response

Log(s) & preferences file(s)

No response

AdaBallard avatar Dec 07 '22 10:12 AdaBallard

Qbtheme I've been successfuly using for 2 years (the link is below) stopped working after 4.5.0 and just shows the default interface when enabled.

And what, there are no related messages in the log? BTW, what do you expect from this theme? According to its description "This is a very minimal qbtheme for qBittorrent that brings back the compact layout for the transfer list from pre-4.2.2.". I just tested it on my development build (which is slightly ahead of v4.5), and it really affects the height of some lines.

glassez avatar Dec 07 '22 12:12 glassez

legacy-qBittorrent This is a very minimal qbtheme for qBittorrent that brings back the compact layout for the transfer list from pre-4.2.2. The theme works fine on 4.5.0 (win, qt5).

btw, are you not surprised by the size of the qbtheme file ? useful content - only: stylesheet.qss

b-user avatar Dec 07 '22 12:12 b-user

It's not working on my end (win, qt5 as well). Here is side by side screenshot comparison:

(4.4.5 can display 6 and a half lines of torrent names where 4.5.0 can fit only 5 using the same space with the same custom theme applied on both)

qutor445+450 edited

And yes, there is nothing in log about it it seems.

Tried it with qbittorrent_4.5.0beta1_x64 - still no luck.

AdaBallard avatar Dec 08 '22 12:12 AdaBallard

@AdaBallard So you can't claim that themes (as a feature) don't work, but only that this particular theme behaves differently than it did on the previous version. However, compatibility of themes between qBittorrent versions has never been guaranteed. You could contact the author of the affected theme to try to update it.

glassez avatar Dec 08 '22 13:12 glassez

If I could "try to update it" I would not open this issue in the first place.

Hope it'll work on future versions, as you say build "slightly ahead of v4.5" works properly with it.

AdaBallard avatar Dec 08 '22 14:12 AdaBallard

Hope it'll work on future versions, as you say build "slightly ahead of v4.5" works properly with it.

I didn't say it "works properly" with regard to particular theme, mostly about the feature itself. I just noticed some visual changes after it is applied.

glassez avatar Dec 09 '22 03:12 glassez

@glassez However, compatibility of themes between qBittorrent versions has never been guaranteed.

How to determine the minimum height of a QTreeView (in the default theme) ? I didn't find anything like this in the qbit documentation.

b-user avatar Dec 09 '22 06:12 b-user

@glassez

At least "it really affects the height of some lines" in development build, unlike in official 4.5.0.

AdaBallard avatar Dec 09 '22 10:12 AdaBallard

@glassez

At least "it really affects the height of some lines" in development build, unlike in official 4.5.0.

Actually, it was about the filters widget (there were changes I noticed there), not about the torrents list.

glassez avatar Dec 09 '22 11:12 glassez

Gonna use 4.4.5 forever then it seems.

AdaBallard avatar Dec 09 '22 13:12 AdaBallard

It doesn't work for me either. Arch Linux v4.5.0, Qt 6.4.1. Update 221210 0850 : Log : UI theme - "config.json" could not be opened. Reason: No such file or directory

Piqlet avatar Dec 10 '22 07:12 Piqlet

Log : UI theme - "config.json" could not be opened. Reason: No such file or directory

For me both 4.4.5 and 4.5.0 say it in log, but visual theme works only on 4.4.5.

AdaBallard avatar Dec 10 '22 09:12 AdaBallard

I found this by trial and error, looking at qb code (main window.cpp): adding QWidget::Item to FoxInFlame's QSS, results in a more compact transfer list as expected. However, it affects the Options window icons. File is attached if anyone hopefully wants to fix it: legacy-qBittorrent-7.zip

I also found that what b-user said is related to the files contained in the theme compiling directory. It seems that any files in that folder (legacy-qBittorrent-master) are aggregated when compiling the compact theme, so the size of the theme increases if one does not delete prior generated themes in the same folder.

pesgh avatar Dec 23 '22 15:12 pesgh

added: TransferListWidget::Item::Completed{color: #5c00a0;} legacy-qBittorrent.qbtheme.zip

pesgh avatar Dec 23 '22 16:12 pesgh

Thanks for your help!

Already better results - 6 lines for 4.5.0 vs 6 and half lines for 4.4.5.

qb450 vs 445 with edited compact theme

Hope fixes for this will be incorporated in future versions (unlikely though).

AdaBallard avatar Dec 25 '22 15:12 AdaBallard

@AdaBallard

You're welcome. I managed to fix the icon display in the Options Dialog, if you're still interested. File attached contains 4 .qbtheme alternatives, with two different height values for each color palette. For the dark qbtheme, to which I'm trying to get used, I wanted to set distinctive colors only for the status column in TransferListWidget, but couldn't figure how. QSS needed to address the Options Dialog issue was:

QWidget::Item{
   height: 18px;}
  
QDialog QWidget::Item{
   height: 70px;}

legacy-qBittorrent-alt.zip

pesgh avatar Feb 22 '23 09:02 pesgh