qBittorrent
qBittorrent copied to clipboard
qbittorrent
Add "Rename rule" button to RSS Downloader
This is quite the simple PR. It simply adds a new button to RSS Downloader so people are aware that they can rename. It's just usability, in my opinion.
At the moment, users can press F2 (only found this in source code) and double-click to rename a rule's title. But, there is no real hint about this. So I thought this button would be helpful, especially for the less techie people.
Feel free to reject it, if you don't agree.
@OpenSpaghettiSauce I believe it should be a rule to provide screenshots for any PR affecting UI.
Sorry about that!
I also kinda wanted to add a note that users can actually press F2 and whatnot, but the current red text is a fixed, pre-formatted label. Ie.: no easy way to add into that, unless someone breaks the whole thing and yeah, I already made quite the mess.
I have no preference about the addition, however i should point out that the opposite happened in Search widget i.e. some buttons were removed and replaced with context menu actions https://github.com/qbittorrent/qBittorrent/pull/10852/commits/5b9b5ce577f882fb58284ccfd3f1570f931dac6f. However i should also point out that people complained about it https://github.com/qbittorrent/qBittorrent/issues/12846
At least I wouldn't place this button alongside with Import/Export buttons but with Add/Remove instead.
What's about the case when no rule is selected? "Rename" button should be disabled (I wonder how behaves "Remove" button currently?).
I wonder how behaves "Remove" button currently?).
Not disabled and when clicked it has no effect. Also these buttons don't have tooltip currently (they should IMO since they're icons for actions).
Also these buttons don't have tooltip currently (they should IMO since they're icons for actions).
👍
Thank you guys for the feedback and sorry for wasting your time with such little UI change.
I would also put a little ? button in the top-right corner or somewhere in most windows, explaining a bit more about things. Like here, users can press F2, DEL for example. Things that are not exposed to the user so to say. But that's not related to this PR/change and just my opinion, because there is just so much cool stuff qBittorrent can do but if I haven't looked at the source, I'd have never known.
