qBittorrent
qBittorrent copied to clipboard
Increase ETA time and fix seed time options max value
Closes #17854
Please be gentle, it's my first (horrible) PR.
The ETA currently is fixed to 1 year. This PR changes that to 10 years.
- I compiled it, it ran fine, but please verify. (tested on Manjaro, x64)
- I could not figure out why there was a 1 year limit. Like I could not find any explanation at all. Maybe there is a good reason, and maybe a git wizard can find the reason with some black magic. Please do, if you can. Thank you.
- In some files the limit is expressed in seconds (qlonglong), while in "int", it is expressed in minutes.
- This PR "fixes" the global options seed time limit as well. Previously you were able to set 9999999 value, ignoring the hard-coded 1 year. Since it's a .ui file, I could not find a better way of fixing this. If you used the per-torrent, right-click torrent options dialogue, the set limit was followed.
- I could not find any other occurrence of this limit.
As for why 10 years? Well, "torrent.cpp" had a hard-coded 1 year const, as int. 10 years in minutes is still way below of any limit of an integer, so "it should be fine". Going 20, 30 makes no sense I believe.
Ps.: This is my "user" account, I am @Balls0fSteel. I made this account to avoid any possible "mistakes".
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.
Bump?
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.
This PR was closed because it has been stalled for some time with no activity.