qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Text encoding borked in 4.4.0, was fine on rc1

Open mzso opened this issue 3 years ago • 24 comments

qBittorrent & operating system versions

4.4.0 Win 10 21h2

What is the problem?

I get garbled text, where there should be diacritics. I only saw it in label names that I have created before. New ones don't seem to be affected. kép kép

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

No response

mzso avatar Jan 07 '22 14:01 mzso

Are you sure you had previously used unstable and officially publicly unavailable RC3, not 4.4.0 beta 3 or 4.4.0 rc1?

What language do you have enabled?

PriitUring avatar Jan 07 '22 15:01 PriitUring

@PriitUring commented on 2022. jan. 7. 16:06 CET:

Are you sure you had previously used unstable and officially publicly unavailable RC3, not 4.4.0 beta 3 or 4.4.0 rc1?

I guess not. I remembered rc3, but apparently ( #15925 ) I was using rc1.

What language do you have enabled?

Hungarian. But this part is of course typed by me being tag names.

mzso avatar Jan 07 '22 18:01 mzso

@PriitUring It seems like I found another place where this happens, the save path: kép

And it's a lot more noxious, because the download ends up in a new folder with a garbled folder name.

The tag being broken is a smaller nuisance because you have to add to it manually anyway.

mzso avatar Jan 08 '22 11:01 mzso

Why did you leave important info out from the bug form? What Qt version are you using? See from Help->About->Software used

sledgehammer999 avatar Jan 10 '22 23:01 sledgehammer999

@sledgehammer999 Well, qt info was superfluous on windows formerlly. Anyway it's the qt6 version.

mzso avatar Jan 11 '22 21:01 mzso

@mzso can you try with the qt5 version and see if the encoding is fixed?

sledgehammer999 avatar Jan 11 '22 22:01 sledgehammer999

@sledgehammer999 commented on 2022. jan. 11. 23:28 CET:

@mzso can you try with the qt5 version and see if the encoding is fixed?

Not sure if that's an invitation for trouble. Anyway I already downgraded to RC1 where it was still correct, but the text didn't get restored. Maybe text got permanently garbled during the update to final?

mzso avatar Jan 11 '22 23:01 mzso

PS: I wonder why can tags can exist that's for torrents that don't exist in the tags section. Specifically for this issue I used to have the tag "Könyv", now I have "Könyv". But due to #15997 I had stuff that I recovered, so one torrent now has both in the tags column, but only the garbled text category exists in the tags section of the sidebar.

Also it seems the broken tag is saved in the fastresume files as well, at least when I view one in Total Commander's lister (UTF-8 mode) I see: kép

mzso avatar Jan 11 '22 23:01 mzso

Not sure if that's an invitation for trouble.

You do realize that there 2 official installers for 4.4.0. One with qt5 and one with qt6. The qt5 is still considered the stable one while the qt6 one is semi-experimental.

Maybe text got permanently garbled during the update to final?

That's a possibility. Are your tags/categories in non-english characters? Are all affected text non-english?

sledgehammer999 avatar Jan 12 '22 01:01 sledgehammer999

@sledgehammer999 commented on 2022. jan. 12. 02:12 CET:

Not sure if that's an invitation for trouble.

You do realize that there 2 official installers for 4.4.0. One with qt5 and one with qt6. The qt5 is still considered the stable one while the qt6 one is semi-experimental.

I saw no note of Qt6 being less stable than Qt5

Maybe text got permanently garbled during the update to final?

That's a possibility. Are your tags/categories in non-english characters? Are all affected text non-english?

Well, yes. In the issue description I mentioned that it got garbled where characters with diacritic marks were present.

mzso avatar Jan 12 '22 09:01 mzso

I saw no note of Qt6 being less stable than Qt5

News page states "The Qt6 version isn't tested much." - https://www.qbittorrent.org/news.php


Also, the download page has "Semi-experimental version based on Qt6. Needs Windows 10+ (64-bit only)."

semi-experimental

@sledgehammer999 fosshub/sourceforge could be requested to mark the qt6 builds as unstable/experimental & perhaps experimental or similar naming could be added to files like the "Beta/RC" were.

xavier2k6 avatar Jan 12 '22 09:01 xavier2k6

Wasn't there a problem identified?

mzso avatar Jan 27 '22 23:01 mzso

Okay after downgrading because of all the issues and upgrading 4.4.1 the text got even more broken. Now I have for example kép, which is a more broken form of kép, which is the first broken form of the original "könyv".

And I dongraded/upgraded between QT6 versions.

mzso avatar Feb 27 '22 10:02 mzso

It seems like manually re-creating the category with the correct name assigns the torrents tagged as such. (However the counter will show "0" until I restart the client.) However I also have torrents with broken tags so I need to add the proper tags to them as well. Quite a mess.

mzso avatar Feb 27 '22 10:02 mzso

Not only that, but I couldn't remove the broken tags without the tags existing in the sidebar. And I of course had no way of typing it. So I needed to find the .resume file and copy/paste. Thereafter it showed: kép So the counter is rather broken. By the looks of it, it does not check for its tags when created and only keeps increasing/decreasing its value when I change tags in the context menu. Even if it's to nonsensical values.

mzso avatar Feb 27 '22 10:02 mzso

Is this still a problem?

luzpaz avatar Jul 18 '22 19:07 luzpaz

@luzpaz commented on 2022. júl. 18. 21:19 CEST:

Is this still a problem?

Probably. I have not tried to upgrade again from rc1 to 4.4.0

mzso avatar Jul 18 '22 22:07 mzso

Current stable is v4.4.3.1
Is there a way you can check on another machine?

luzpaz avatar Jul 18 '22 22:07 luzpaz

@luzpaz Check how? Upgrading from RC1 to 4.4.0? Seems pointless, since no-one will use that pre-release again.

mzso avatar Jul 19 '22 14:07 mzso

The problem came back with 4.4.5. My guess for the cause is: "The default builds for all OSs switched to libtorrent 1.2.x (RC_1_2) from 2.0.x (RC_2_0). "

Though it manifests differently. The tags got duplicated this time one borked and empty, and correct with diacritics: kép

In the save path MRU the paths with diacritics are just plain broken.

mzso avatar Sep 02 '22 12:09 mzso

@mzso there's 6 different installers for Windows OS of qBittorrent v4.4.5, so there could be something else in qBittorrent code or Qt versions not just changing between libtorrent versions to something different.

Did you backup your previous qBittorrent v4.4.0rc1 folders containing settings and resume files before trying v4.4.5?

Can you give list of original tag names you had previously?

You know you can filter, sort and highlight multiple torrents, add different tag and then remove borked tag?

PriitUring avatar Sep 02 '22 13:09 PriitUring

@PriitUring No, 4.4.0rc1 was long time ago, I just reported that it happened again. Upgrading from 4.4.3.1 to 4.4.4/4.4.5.

Kind of sad that these things are not considered. I provided a sample of good/borked text via the image.

You know you can filter, sort and highlight multiple torrents, add different tag and then remove borked tag?

Of course. Doesn't help with the MRU though.

mzso avatar Sep 02 '22 13:09 mzso

@mzso

No, 4.4.0rc1 was long time ago, I just reported that it happened again. Upgrading from 4.4.3.1 to 4.4.4/4.4.5.

Previously there was less installers to choose from and currently there's 6 different installers of qBittorrent v4.4.5 for Windows users and it's not easy to guess that you where able to reproduce even with a specific installer or with all previous qBittorrent versions or what are the exact steps to reproduce on another computer if you didn't write it before.

All you wrote before was:

  • on 27 February: tried v4.4.1 and went back to v4.0.0rc1.
  • on 19 July you wrote that you haven't tried upgrading.

I mentioned before that you can backup your things so you could easily test things yourself on same or on another computer, then others wouldn't need to try guessing anything or spend their free time trying different installers with different dependencies.

Kind of sad that these things are not considered. I provided a sample of good/borked text via the image.

Deciphering borked text to original is time consuming, not everyone knows how to do something as such. If you have instructions how to convert garbled borked text and how to copy from an image then would be good to share that to have more luck finding others to confirm or fix your issue if not bothered writing the borked text.

If you are unable unable to provide original tag names you had or copy broken text as a text instead of an image or other easy to follow steps, then it's delaying fixing things if other users don't know quick reliable way to reproduce and confirm that issue happens even with their computer.

Unfortunately this is free software and unpaid volunteers use their free time to improve software and if opening post doesn't include enough information to quickly reproduce or following comments don't specify enough basic valuable information then can't do much about it to get things fixed quicker.

If developers know the exact cause, have a solution or created a pull request with a fix then then someone would have already mentioned it here.

PriitUring avatar Sep 02 '22 19:09 PriitUring

@PriitUring

Previously there was less installers to choose from and currently there's 6 different installers of qBittorrent v4.4.5 for Windows users and it's not easy to guess that you where able to reproduce even with a specific installer or with all previous qBittorrent versions or what are the exact steps to reproduce on another computer if you didn't write it before.

Too many in fact. It look like I accidentally upgraded from QT6 4.4.4 to QT5 4.4.5. (Both libtorrent 1.2) So it's likely not the change from libtorrent versions from 4.4.3.1 to 4.4.4 is what caused this.

Deciphering borked text to original is time consuming, not everyone knows how to do something as such.

You weren't asking for that explicitly. And I didn't see any use for that since it already seemed obvious there's some text encoding conversion failure that happened. Also, I'm not sure how to copy the text. There's no edit feature, or any way to select them. Edit: I found it in the ini file: Könyv vs Könyv, Játék vs Játék.

mzso avatar Sep 03 '22 06:09 mzso

Edit: I found it in the ini file: Könyv vs Könyv, Játék vs Játék.

What does this mean ?

luzpaz avatar Sep 01 '23 15:09 luzpaz

Thanks @PriitUring for that detailed response.
What's the verdict here ? 'Wont fix' ?

luzpaz avatar Nov 14 '23 12:11 luzpaz

@luzpaz Since there are no more QT5 builds I doubt that effort will be put into fixing the upgrade to QT6. And no-one else seems to have been bothered enough to make it to this issue ticket.

mzso avatar Nov 15 '23 19:11 mzso