qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Search stopped functioning in 4.3.0

Open mzso opened this issue 3 years ago • 11 comments

Please provide the following information

qBittorrent version and Operating System

3.4.0 Win 10

What is the problem

No search tab. I got a warning that Python version 3.4.4 is outdated, and the minimum version is 3.3.0. So that was already suspicious. So when I selected yes, 3.5.0 was installed. Yet it still doesn't work. And I get the exact same warning when clicking the search engines item in the view menu

What is the expected behavior

Search not being broken because of bogus version number issues

Extra info(if any)

The warning text seems to be borked as well: kép

Superfluous bracket and a {1}.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

mzso avatar Oct 19 '20 09:10 mzso

Looks like https://github.com/qbittorrent/qBittorrent/pull/13268 did not update the text properly in all places: https://github.com/qbittorrent/qBittorrent/pull/13268/files#diff-50b364e3b4577505a4662971abc19f01aed81ec7d910fd20fd22fb139c3d896eL1800.

Also some kind of translation bug might be lurking?

FranciscoPombal avatar Oct 19 '20 10:10 FranciscoPombal

The version in the title should be 4.3.0 not 3.4.0.

zywo avatar Oct 19 '20 19:10 zywo

@FranciscoPombal commented on 2020. okt. 19. 12:31 CEST:

Looks like #13268 did not update the text properly in all places: https://github.com/qbittorrent/qBittorrent/pull/13268/files#diff-50b364e3b4577505a4662971abc19f01aed81ec7d910fd20fd22fb139c3d896eL1800.

Also some kind of translation bug might be lurking?

Which means search is effectively completely broken until this is fixed?

Would installing an even newer python version help?

mzso avatar Oct 23 '20 11:10 mzso

@mzso

Which means search is effectively completely broken until this is fixed?

No, it means the text on the dialog is inaccurate.

Would installing an even newer python version help?

Everything works fine on my machine with Python 3.9, and as far as I know, everything is OK with any recent python version as well (greater than the minimum version). You may be having issues with the PATH on your system and/or multiple Python installations.

FranciscoPombal avatar Oct 23 '20 12:10 FranciscoPombal

@FranciscoPombal commented on 2020. okt. 23. 14:26 CEST:

@mzso

Which means search is effectively completely broken until this is fixed?

No, it means the text on the dialog is inaccurate.

Would installing an even newer python version help?

Everything works fine on my machine with Python 3.9, and as far as I know, everything is OK with any recent python version as well (greater than the minimum version). You may be having issues with the PATH on your system and/or multiple Python installations.

Everything is not okay. As I said can't get search to function at all with 4.3.0 (or 4.3.0.1). Whenever I try to enable the search I get the same useless alert. And even if I run the installer offered (successfully) nothing changes. Everything's fine if I use an earlier alpha shared here on github. (qBittorrent-nightly-e16aafb_vcpkg-fdac1fc_qt5-lts-5.15.0_libtorrent-release-1.2.10_x64-static-release) With official release no usable search feature...

mzso avatar Oct 23 '20 13:10 mzso

@FranciscoPombal commented on 2020. okt. 23. 14:26 CEST:

You may be having issues with the PATH on your system and/or multiple Python installations.

QB should use the appropriate one, shouldn't it? Especially if QB initiated the python update.

mzso avatar Oct 23 '20 13:10 mzso

@FranciscoPombal Also how everything could be working fine when QB requests an update even though the installed version shown is higher then the minimum it requests, and even installing the upgrade doesn't work? It also claims to install 3.5.0, but it actually gets 3.8.5 as shown in the pull you linked. Everything's a mess.

mzso avatar Oct 23 '20 13:10 mzso

@mzso

Look, there might indeed be a bug in version selection/detection in some cases, but that is far from search being "effectively completely broken".

Do you have a chance to debug qBittorrent on your system to figure out what's wrong? Without that or detailed steps to reproduce it is hard for others to find the problem and fix it. As I said, I tried myself on one of my machines and it worked.

FranciscoPombal avatar Oct 23 '20 17:10 FranciscoPombal

@FranciscoPombal Well, removing 3.4.4 helped, but this sucks no matter how I look at it. Self-contradicting error message. Broken search feature. And you need to do something manually, that you can't even know if you're not a dev.

mzso avatar Oct 23 '20 18:10 mzso

Also having this issue, clicking the in-program box to install the required version installs Python 3.8, but when trying to enable search, it still detects older versions of python.

SquirrelsMcGee avatar Nov 22 '20 00:11 SquirrelsMcGee

Is this still an issue?

ghost avatar Aug 09 '22 15:08 ghost

IS this still relevant ?

luzpaz avatar Jul 05 '23 15:07 luzpaz

@luzpaz Potentially. I don't know why it happened.

mzso avatar Jul 05 '23 17:07 mzso

The warning text seems to be borked as well: kép

This issue (as pointed out) in https://github.com/qbittorrent/qBittorrent/issues/13541#issuecomment-712008266 was an oversight & I fixed the dialog discrepancy & updated the installers in 4.4.0 via PR #15467

Screenshot 2023-07-05 192913


In relation to not getting search to work, I can't reproduce & I installed Python 3.4.4 & Python 3.8.10 for testing purposes.

Screenshot 2023-07-05 193504


In qBittorrent 4.6.0+ the minimum Python version has been raised via PR #18996 to 3.7.0 & there will be 2 installer versions offered to cater for Windows 7/8 userbase (3.8.10) & Windows 10+ userbase (3.10.11)

@mzso Can you provide anything else? ~I consider this resolved otherwise....~ WIP....have discovered another oversight in master....should be resolved soon.

xavier2k6 avatar Jul 05 '23 18:07 xavier2k6

@xavier2k6 I have nothing else. It happened then with an unknown cause, but not since then. I guess you can close it, when that impending fix lands.

mzso avatar Jul 05 '23 20:07 mzso

Other issue that I previously found is fixed via PR #19281.

@mzso Is the search feature working for you now in latest qBittorrent 4.5.4 or qBittorrent 4.6.0 beta??

xavier2k6 avatar Jul 06 '23 09:07 xavier2k6

@xavier2k6 Yes. The problem never resurfaced again.

mzso avatar Jul 06 '23 10:07 mzso

I guess it can be closed then.

mzso avatar Jul 06 '23 10:07 mzso