rnadeseq icon indicating copy to clipboard operation
rnadeseq copied to clipboard

Published 20 hours ago • verified publisher icon qbic-pipelines

Release 2.3

Open WackerO opened this issue 1 year ago • 2 comments

PR checklist

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • [ ] Make sure your code lints (nf-core lint).
  • [ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • [ ] Usage Documentation in docs/usage.md is updated.
  • [ ] Output Documentation in docs/output.md is updated.
  • [ ] CHANGELOG.md is updated.
  • [ ] README.md is updated (including new tool citations and authors/contributors).

WackerO avatar May 07 '24 13:05 WackerO

This PR is against the master branch :x:

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @WackerO,

It looks like this pull-request is has been made against the qbic-pipelines/rnadeseq master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the qbic-pipelines/rnadeseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

github-actions[bot] avatar May 07 '24 13:05 github-actions[bot]

nf-core lint overall result: Passed :white_check_mark: :warning:

Posted for pipeline commit acd0dbd

+| ✅ 171 tests passed       |+
#| ❔  15 tests were ignored |#
!| ❗   3 tests had warnings |!

:heavy_exclamation_mark: Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.3
  • readme - README did not have a Nextflow minimum version badge.
  • schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

:grey_question: Tests ignored:

  • files_exist - File is ignored: lib/nfcore_external_java_deps.jar
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config default ignored: params.report_file
  • nextflow_config - Config default ignored: params.references_file
  • nextflow_config - Config default ignored: params.custom_config_base
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore

:white_check_mark: Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-13 11:33:14

github-actions[bot] avatar May 07 '24 13:05 github-actions[bot]

As https://nfcore.slack.com/archives/CE6SDBX2A/p1663077291333929 and https://nfcore.slack.com/archives/C02AL61NXPH/p1651131006534289 describe the same issue with the failing branch protection, and I could not find any solution there (and my attempts to fix it also failed), I'm going to ignore this error and merge. Maybe it will resolve itself in the future but in this case, it is not a problem IMO.

WackerO avatar Jun 13 '24 13:06 WackerO