qb-core icon indicating copy to clipboard operation
qb-core copied to clipboard

Performance, notification, and localization updates to `server/commands.lua`

Open Asaayu opened this issue 2 years ago • 1 comments

Describe Pull request Performance, notification, and localization updates to server/commands.lua.

  • Performance - Change ace permissions loop from a pairs() to a for-i loop as recommended in Lua performance test #9
  • Notification  - Added success notifications for openserver and closeserver commands
  • Localization  - Added missing localization strings for openserver and closeserver commands

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality? Yes
  • Does your code fit the style guidelines? Yes
  • Does your PR fit the contribution guidelines? Yes

Asaayu avatar Apr 13 '22 15:04 Asaayu

@Asaayu Please update Branch

amantu-qbit avatar Jul 29 '22 11:07 amantu-qbit