qb-core icon indicating copy to clipboard operation
qb-core copied to clipboard

[Update] Stuff and Things - Fix Exploit

Open ItsANoBrainer opened this issue 2 years ago • 14 comments

  • Support for heading with TeleportToCoords event
  • Support for teleporting to location name with /tp and a default file with locations to use
  • Remove 'QBCore:Server:AddItem' event (requires PR to other resources that use it)
  • Support for an array of items that do the same thing with QBCore.Functions.CreateUsableItem
  • Player exists check before removing or adding permission
  • Trigger OnPlayerUnload as a server side event too
  • Player.Functions.GetMetaData function
  • Added reason to money remove logs
  • Set dirt level to 0 on /car vehicles

The following PRs reflect the removal of QBCore:Server:AddItem: https://github.com/qbcore-framework/qb-prison/pull/63 https://github.com/qbcore-framework/qb-smallresources/pull/199 https://github.com/qbcore-framework/qb-drugs/pull/55 https://github.com/qbcore-framework/qb-inventory/pull/251

ItsANoBrainer avatar Mar 03 '22 06:03 ItsANoBrainer

@IdrisDose Finished current requested changes. Please verify the deprecation is what you wanted.

ItsANoBrainer avatar Mar 03 '22 07:03 ItsANoBrainer

regarding bb5ea4d

I was meaning the same way I've done it before #442 so it doesn't run the function just prints it in the server console.

IdrisDose avatar Mar 06 '22 10:03 IdrisDose

This looks good but

Update doors on teleport so they don't get stuck (requires my doorlock PR that creates an updateDoors event

This is more of a workaround than a fix, I would rather fix this issue in qb-doorlock instead of making resources that change your location require to call this event

BerkieBb avatar Mar 06 '22 11:03 BerkieBb

This is more of a workaround than a fix, I would rather fix this issue in qb-doorlock instead of making resources that change your location require to call this event

Agreed

ItsANoBrainer avatar Mar 06 '22 21:03 ItsANoBrainer

@ItsANoBrainer conflicterinos

IdrisDose avatar Mar 17 '22 21:03 IdrisDose

@IdrisDose Done

ItsANoBrainer avatar Mar 17 '22 21:03 ItsANoBrainer

the tp to locations just pops the Player not Online notification no errors

@vBooya You did not pull it properly then, because I just setup a vanilla qb-core recipe from tx and had no issues. Try repulling.

ItsANoBrainer avatar Mar 18 '22 01:03 ItsANoBrainer

hopefully someone else can confirm it works, i literally went over it twice and copy pasted so i didnt mess up any typing

llbooya avatar Mar 20 '22 18:03 llbooya

@ItsANoBrainer

llbooya avatar Mar 20 '22 18:03 llbooya

image One of my devs cannot load into the server. He has no character at all and this is the error message. There was another error before but I fixed it by adding the following: image The issue is, that its trying to access PlayerData.job.name but PlayerData.job / PlayerData.gang is nil. image

JonasDev17 avatar Mar 22 '22 19:03 JonasDev17

Nevermind, just saw it has been fixed

JonasDev17 avatar Mar 22 '22 19:03 JonasDev17

@ItsANoBrainer lets get this merged

BerkieBb avatar Jul 10 '22 07:07 BerkieBb

This failing check is literally bullshit

BerkieBb avatar Jul 23 '22 21:07 BerkieBb

Nevermind

BerkieBb avatar Jul 23 '22 21:07 BerkieBb