qb-core icon indicating copy to clipboard operation
qb-core copied to clipboard

Fixed missing return statement in Player.Functions.HasItem

Open AdrianCeku opened this issue 1 year ago • 5 comments

Description

self.Functions.HasItem calls QBCore.Functions.HasItem, but does not return any value due to a missing return statement.

I added the return statement so the function can be called from the Player Object instead of having to resort to calling QBCore.Function.HasItem and passing the source manually

Checklist

  • [x] I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • [x] My code fits the style guidelines.
  • [x] My PR fits the contribution guidelines.

AdrianCeku avatar Feb 27 '24 20:02 AdrianCeku

This PR has had 60 days of inactivity & will close within 7 days

github-actions[bot] avatar May 02 '24 15:05 github-actions[bot]

@Z3rio is this gonna be merged? This PR is literally one Word so I dont think it should take too much effort to merge

AdrianCeku avatar May 02 '24 16:05 AdrianCeku

@Z3rio is this gonna be merged? This PR is literally one Word so I dont think it should take too much effort to merge

I believe you might be a bit confused. I do not have any affiliation with the qbcore organization, nor can I merge PRs. The only one who can merge PRs would be @GhzGarage

Z3rio avatar May 02 '24 16:05 Z3rio

@Z3rio oh im sorry. I just assumed you were a dev form qb-core because but I should have probably checked beforehand 😅. My apologies

AdrianCeku avatar May 02 '24 16:05 AdrianCeku

@Z3rio oh im sorry. I just assumed you were a dev form qb-core because but I should have probably checked beforehand 😅. My apologies

No worries, I used to do a lot of work for qbcore as I was the dev manager back then, so I understand why you might've thought that :)

Z3rio avatar May 02 '24 16:05 Z3rio

I was the one that changed that file with a PR previously, my bad. This PR should be merged.

Cocodrulo avatar May 06 '24 20:05 Cocodrulo