qb-core icon indicating copy to clipboard operation
qb-core copied to clipboard

Backwards compatibility for vehicles.lua

Open xDope7137 opened this issue 2 years ago • 8 comments

Description

you can just drag and drop the vehicles from older vehicles.lua now

Checklist

  • [x ] I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • [x] My code fits the style guidelines.
  • [x] My PR fits the contribution guidelines.

xDope7137 avatar Dec 01 '23 20:12 xDope7137

bad idea https://stackoverflow.com/questions/71276468/what-is-the-fastest-way-to-go-through-an-array-table-with-numeric-indices

766974616c79 avatar Dec 05 '23 06:12 766974616c79

bad idea https://stackoverflow.com/questions/71276468/what-is-the-fastest-way-to-go-through-an-array-table-with-numeric-indices

buddy read the whole topic. they are enumerating 100,000+ values. People do not have more than 500 vehicles in that file.

by that logic, nothing should be using pairs. It does not sense to make it work for all small sized tables.

Besides, are you going to let all server owners to convert their whole car tables to new layout? To save 0.2ms compute time? Just one time every restart? smh

xDope7137 avatar Dec 06 '23 22:12 xDope7137

image

xDope7137 avatar Dec 06 '23 23:12 xDope7137

I'm just offering my opinion

766974616c79 avatar Dec 07 '23 11:12 766974616c79

This PR has had 60 days of inactivity & will close within 7 days

github-actions[bot] avatar Feb 05 '24 15:02 github-actions[bot]

qb dead?

xDope7137 avatar Feb 07 '24 20:02 xDope7137

This PR has had 60 days of inactivity & will close within 7 days

github-actions[bot] avatar Apr 09 '24 15:04 github-actions[bot]

qb dead dead

xDope7137 avatar Apr 10 '24 18:04 xDope7137