goreporter icon indicating copy to clipboard operation
goreporter copied to clipboard

Improvements in code design

Open arthurgustin opened this issue 7 years ago • 2 comments

Hello, I've worked on a pull request, and I found it hard to read the code: there are several big functions and a lot of repetitions. I have identified the strategy pattern to handle the different linters, what do you think about a possible rework of the code base ?

arthurgustin avatar Jul 26 '17 15:07 arthurgustin

Nice. You say it makes sense. Code optimization work I have improved in feature-3.0.You can see if there is a need to optimize the place. Please re-commit code to ensure that unit testing and annotations are complete in the branch feature-3.0.

wgliang avatar Jul 27 '17 02:07 wgliang

Alright, if I have time this weekend I will have a look

arthurgustin avatar Jul 27 '17 09:07 arthurgustin