goreporter icon indicating copy to clipboard operation
goreporter copied to clipboard

respect build instructions like // +build go1.9

Open Dexus opened this issue 8 years ago • 4 comments

Please dont run into crashes while disrespect // +build go1.9 comments... Cant check now my own code, because of use 1.8.3 but the tools check also go1.9 code...

Dexus avatar Jul 19 '17 10:07 Dexus

go1.9beta2 is not a stable version and I did not test whether it was supported. You can post your error and I will test it!

wgliang avatar Jul 19 '17 10:07 wgliang

github.com/go-siris/siris Error: github.com/go-siris/siris/vendor/golang.org/x/net/ipv6/batch.go:56:14: expected type, found '=' (and 1 more errors)

Dexus avatar Jul 19 '17 11:07 Dexus

I have tested siris. The error message is not goreporter does not skip the vendor directory,but siris required these packages in the unit test , so you must ensure that the project is runable.

wgliang avatar Jul 19 '17 11:07 wgliang

yeah, i have add now all the sources but its fails with the abdove error.

Dexus avatar Jul 19 '17 13:07 Dexus