excelize icon indicating copy to clipboard operation
excelize copied to clipboard

Fix: Issue #1936 CalcCellValue silently fails when formula is =OTHER_FORMULA

Open abdelaziz-ouhammou opened this issue 1 year ago • 2 comments

Fix: Issue #1936 CalcCellValue silently fails when formula is =OTHER_FORMULA

PR Details

Return Error if it doesn't have "#N/A"

Related Issue

CalcCellValue silently fails when formula is =OTHER_CELL and OTHER_CELL has a formula evaluation error #1936

How Has This Been Tested

I added a unit test for the changes.

Types of changes

  • [X] Bug fix (non-breaking change which fixes an issue)

Checklist

  • [X] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [X] I have read the CONTRIBUTING document.
  • [X] I have added tests to cover my changes.
  • [X] All new and existing tests passed.

abdelaziz-ouhammou avatar Jul 22 '24 13:07 abdelaziz-ouhammou

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.31%. Comparing base (d81b4c8) to head (dd5c57a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1962   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          32       32           
  Lines       24981    24983    +2     
=======================================
+ Hits        24809    24811    +2     
  Misses         92       92           
  Partials       80       80           
Flag Coverage Δ
unittests 99.31% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 22 '24 13:07 codecov[bot]

What is missing for this to be merged?

paolobarbolini avatar Aug 14 '24 07:08 paolobarbolini