excelize icon indicating copy to clipboard operation
excelize copied to clipboard

#1402 Get CountRows from sheet

Open ivolkoff opened this issue 3 years ago • 0 comments

PR Details

Get CountRows from sheet

Description

Get CountRows from sheet

Related Issue

https://github.com/qax-os/excelize/issues/1402

Motivation and Context

Current solutions are slow. My solution is fast.

file 1М rows

- - -
BenchmarkFile_GetRows_Old-8 1 5797898958 ns/op
BenchmarkFile_GetRows_New-8 3 411330472 ns/op

How Has This Been Tested

Run test TestFile_CountRows

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

ivolkoff avatar Nov 25 '22 15:11 ivolkoff