excelize icon indicating copy to clipboard operation
excelize copied to clipboard

Published 20 hours ago • verified publisher icon qax-os

add auto fit columns function

Open yyt030 opened this issue 2 years ago • 8 comments

PR Details

add auto fit columns function

Description

add auto fit columns function

Related Issue

#92

Motivation and Context

How Has This Been Tested

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

yyt030 avatar Nov 05 '22 14:11 yyt030

Little suggestion for you guys: Maybe can add the feature to check if the cell has the Chinese or Japanese or other bigger font type For me I use unicode.Is to check the unicode.Han, and plus the column width for every single word

Noah-Chiu avatar Nov 09 '22 09:11 Noah-Chiu

Little suggestion for you guys: Maybe can add the feature to check if the cell has the Chinese or Japanese or other bigger font type For me I use unicode.Is to check the unicode.Han, and plus the column width for every single word

I rewrite the function to calculate length of sbcs and mbcs.

yyt030 avatar Nov 15 '22 15:11 yyt030

Has this pull request not been merged into master yet?

hq2333 avatar Aug 04 '23 04:08 hq2333

Has this pull request not been merged into master yet?

There are some code review issues still not resolved. We need to resolve these issues before merging it into the master branch.

xuri avatar Aug 18 '23 07:08 xuri

What's missing for this PR to be merged? All conversations on the "Files" tab seem to be resolved (although idk if truly accepted).

If there's still logic pending for review, broken or missing, I might be able to help.

n3m avatar Jan 16 '24 19:01 n3m

need this feature. any updates

edwardmatutino avatar Jan 19 '24 00:01 edwardmatutino

Hi @yyt030, @n3m, @edwardmatutino, the character width is related to the font family and font size style, we need to calculate column width by font size. I have marked the unresolved comments in the code review conversion. In addition, there's a code conflict in this pull request, we need to resolve this for merging this, and before that please also reference the code in issues #92 and #204.

xuri avatar Jan 19 '24 05:01 xuri