excelize icon indicating copy to clipboard operation
excelize copied to clipboard

Stream writer improvements

Open harrison3000 opened this issue 3 years ago • 2 comments

PR Details

This PR adds miscellaneous improvements to the stream writer API

Description

  • Adds SetPanes
  • Adds AutoFilter
  • Allows calling SetColWidth after rows have already been written
  • Adds a new type SharedString to use shared strings on stream mode on a opt-in manner

Related Issue

#1047

Motivation and Context

These changes make the stream API more flexible and less restricted

How Has This Been Tested

For now I only tested generating large sheets with real world data I also looked at the xml and compared to another xml generated on normal mode Automated tests on the way

Types of changes

  • [x] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

harrison3000 avatar Jan 18 '22 02:01 harrison3000

please review this PR, I have nothing more to add, it just need the finishing touches

harrison3000 avatar Jan 22 '22 01:01 harrison3000

Codecov Report

Merging #1123 (72db604) into master (2f5704b) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1123   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files          31       31           
  Lines       23459    23469   +10     
=======================================
+ Hits        23095    23105   +10     
  Misses        242      242           
  Partials      122      122           
Flag Coverage Δ
unittests 98.44% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
errors.go 100.00% <ø> (ø)
sheet.go 100.00% <100.00%> (ø)
stream.go 90.23% <100.00%> (+0.11%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jan 22 '22 16:01 codecov-commenter