qbraid-qir icon indicating copy to clipboard operation
qbraid-qir copied to clipboard

Add tests for `qbraid_qir/qasm3/maps.py`

Open ryanhill1 opened this issue 11 months ago • 6 comments

Bring qbraid_qir/qasm3/maps.py from 21.36% code coverage (current) to >90% coverage. Tests are missing for ~160 lines of code in that file.

Implementation

  • Since we use pyqasm.unroll method in the qbraid-qir converter, some gate definitions are directly picked up from pyqasm gate map and unrolled. First step of this issue would be identify and remove the gate definitions which have been migrated to pyqasm/src/maps/gates.py
  • Post that, add unit tests for each of the remaining gate definitions which are not covered already.
  • For reference, refer to the unit tests for gates in qbraid-qir - [1], [2]

ryanhill1 avatar Jan 23 '25 15:01 ryanhill1

I’m comfortable writing tests and working with Python. I can help clean up the unused gate definitions and add tests to improve the coverage for maps.py. Please let me know if I can work on this — thanks!

kingjosmel avatar May 28 '25 17:05 kingjosmel

@kingjosmel Sounds great, go for it!

ryanhill1 avatar May 28 '25 17:05 ryanhill1

@ryanhill1 thanks do I need to be assigned or I can just go ahead with it

kingjosmel avatar May 28 '25 17:05 kingjosmel

Just assigned you šŸ‘

ryanhill1 avatar May 28 '25 17:05 ryanhill1

Hi @ryanhill1 @kingjosmel just a small update regarding issue assignment.

This year, the unitary hack organizers have asked us to only assign issues when respective PRs have been merged. So @kingjosmel you're welcome to work on this issue, but the assignment can only be done once the issue is closed with a merged PR.

TheGupta2012 avatar May 30 '25 04:05 TheGupta2012

Hi @ryanhill1 @kingjosmel just a small update regarding issue assignment.

This year, the unitary hack organizers have asked us to only assign issues when respective PRs have been merged. So @kingjosmel you're welcome to work on this issue, but the assignment can only be done once the issue is closed with a merged PR.

@TheGupta2012 ok thank you

kingjosmel avatar May 30 '25 05:05 kingjosmel

@Gmin2, can you please comment on this issue so that I can assign it to you? Your PR is about to be merged and we'll need to assign the issue for bounty distribution

TheGupta2012 avatar Jun 07 '25 08:06 TheGupta2012

Thanks

Gmin2 avatar Jun 07 '25 08:06 Gmin2