nina

Results 116 comments of nina

fixed it properly... i think: https://github.com/chimera-linux/cports/commit/c9bd817091d8db290c195bee831f19379fef854b (why is arithmetic so hard :P)

there is nothing on those pages indicating that using basic_string with non-character types is undefined, and the only way to fix it is to actually not do that

this seems to be due to downloadOverscanRowCount=500 (increasing it also increases the amount of colored log) in `www/base/src/components/LogViewer/LogViewer.tsx`, but i have no idea what a proper fix would look like...

this does not seem to fully map from certain number; setting it to less than 2500 will cut off coloring in log viewer at the number, but setting it to...

the lua metamethod semantics don't allow this to work, quoting reference manual: >"eq": the == operation. The function getcomphandler defines how Lua chooses a metamethod for comparison operators. A metamethod...

you can convert the lua number to a boxed number and then do equality comparison

There is also another separate issue and that is when a color is set overriding the previous color without performing an explicit reset, that is unhandled here (the previous color...

i think the fix for that would be to change ``` for (let i of ansiClasses) { if ((i === '39') || (i === '0')) { // "color reset" code...

a naive way to address that is probably like ``` index a4896c52f..651a910f5 100644 --- a/www/base/src/util/AnsiEscapeCodes.tsx +++ b/www/base/src/util/AnsiEscapeCodes.tsx @@ -92,6 +92,17 @@ export function ansiSgrClassesToCss(ansiClasses: string[], cssClasses: {[key: st if ((i...

do you have any comments wrt the fix for the above issue that i did not include in the patch?