boa-constrictor icon indicating copy to clipboard operation
boa-constrictor copied to clipboard

Questions written to the `Actor` log do not include the `Actor` prefix.

Open Pressacco opened this issue 1 year ago • 1 comments

Background

  • The Screenplay Actor generates a nice "plain English" log file which can be reviewed post-test run.

Actual Behavior

The following is missing when the response to a question is logged:

  1. The actor's name.
  2. Context.
2023-03-09 20:47:07Z [INFO] Adding Ability for 'Dr. Watson' to build widgets.
2023-03-09 20:47:07Z [INFO] 'Dr. Watson' attempts to focus on WidgetApp.exe
2023-03-09 20:47:10Z [INFO] 'Dr. Watson' asking for 'CreateButton' is enabled
2023-03-09 20:47:10Z [INFO]  'CreateButton' is enabled was True

Expected behavior

For consistency, all log entries should be prefixed with:

  1. The actor's name (e.g. 'Dr. Watson').
  2. Context (e.g. observed that the).
2023-03-09 20:47:07Z [INFO] Adding Ability for 'Dr. Watson' to build widgets.
2023-03-09 20:47:07Z [INFO] 'Dr. Watson' attempts to focus on WidgetApp.exe
2023-03-09 20:47:10Z [INFO] 'Dr. Watson' asking for 'CreateButton' is enabled
2023-03-09 20:47:10Z [INFO] 'Dr. Watson' observed that the 'CreateButton' is enabled was True

Steps to reproduce

None at this time.

Boa Constrictor version

3.0.3

Browsers

No response

Operating systems

Windows

Anything else?

On Discord AutomationPanda suggested that I create a Pull Request.

Commitments

  • [X] I agree to follow Boa Constrictor's Code of Conduct.
  • [X] I want to work on this issue myself. (This is voluntary, not required.)

Pressacco avatar Mar 09 '23 23:03 Pressacco

Like #257 , this is a really good idea.

AutomationPanda avatar May 25 '23 01:05 AutomationPanda