c3 icon indicating copy to clipboard operation
c3 copied to clipboard

Interaction picture

Open nwittler opened this issue 3 years ago • 1 comments

What

Introduce interaction picture simulations.

Why

closes #213

How

TBD

Remarks

This includes sizeable cleanup of the model based simulation code.

Checklist

Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the - [x] prefix

  • [ ] Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • [ ] Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • [ ] Type Annotations - All new code has been type annotated in the function signatures using type hints
  • [ ] Docstrings - Docstrings have been provided for functions in the numpydoc style
  • [ ] Documentation - The tutorial style documentation has been updated to explain changes & new features
  • [ ] Notebooks - Example notebooks have been updated to incorporate changes and new features
  • [ ] Changelog - A short note on this PR has been added to the Upcoming Release section

nwittler avatar Jun 10 '22 15:06 nwittler

This pull request introduces 1 alert when merging 804a9da4df53995eb1468c4ec1feeb7715d94e6e into 369f3d128cb7990b5be129e8f90aed2769d459ba - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Jun 10 '22 16:06 lgtm-com[bot]