ts-unused-exports icon indicating copy to clipboard operation
ts-unused-exports copied to clipboard

Fix and Automate the release process to speed up development

Open mrseanryan opened this issue 3 years ago • 5 comments

Use github actions to fully automate the release process.

So when a trusted contributor merges to master, a release is automatically pushed to npm.

This will speed up development, and avoid having PRs waiting for significant time...

mrseanryan avatar Oct 11 '21 11:10 mrseanryan

@pzavolinsky what do you think?

Currently it seems a bit difficult to get PRs processed, so I'm a bit reluctant to spend a lot more time unfortunately on this project in its current state ... :(

mrseanryan avatar Oct 11 '21 11:10 mrseanryan

related = #48

mrseanryan avatar Oct 11 '21 12:10 mrseanryan

hi @pzavolinsky actually now travis is broken completely ...

So cannot merge branches to master (since there is a check using travis...)

If you can add me permissions, I would be happy to sort out the build + release, using github actions

Otherwise this project is kinda stuck now ... 😢

mrseanryan avatar Jan 09 '22 15:01 mrseanryan

example = https://github.com/mrseanryan/eslint-plugin-ts-ban-snippets/blob/main/.github/workflows/node.js.yml

mrseanryan avatar Feb 18 '22 14:02 mrseanryan

hi @pzavolinsky could you please turn OFF the travis integration?

As it stops me from merging :(

I think that is under Settings | Integrated Apps

mrseanryan avatar Feb 18 '22 14:02 mrseanryan

hi @pzavolinsky could we just disable the CI?

as it seems too expensive to fix

mrseanryan avatar Nov 29 '22 11:11 mrseanryan

hi @pzavolinsky after your email, I suddenly figured out how to run github action for PRs

So, at least the "CI" part is working now, via github actions (also for PRs!)

The "CD" part could still be nice (deploy to npm...)

mrseanryan avatar Dec 03 '22 19:12 mrseanryan

The CD part (deploy to npm) can be a separate workflow that is only executed manually.

It could also update the changelog with date and version.

update: have split out a separate 'deploy' workflow, that only has manual trigger.

mrseanryan avatar Dec 04 '22 05:12 mrseanryan

hi @pzavolinsky have pushed fixes to the workflows - regarding #238

But now there seems to be something blocking the publish to npm

Can you have a look?

Sean

mrseanryan avatar Dec 05 '22 19:12 mrseanryan

Hey @mrseanryan I removed the NPM_TOKEN secret while we did our investigation. I just re-enabled it, try again.

pzavolinsky avatar Dec 05 '22 19:12 pzavolinsky

hi @pzavolinsky - now it worked 👍 !

I installed both 8.0.2 and 8.0.3 and the only difference in the package.json files is:

  • typescript ^4.0.0 -> ^4.9.3

which seems OK.

If not - let me know, I can change ...

mrseanryan avatar Dec 05 '22 19:12 mrseanryan

:+1: weird, that it didn't work before.

pzavolinsky avatar Dec 05 '22 20:12 pzavolinsky

Well, I think my deploy 5 failed when the NPM_TOKEN was removed

Then, you added the NPM_TOKEN back.

Then, my deploy 6 succeeded.

Your deploy 7 failed, because that version already publish to npm (8.0.3)

Now, it seems good!

mrseanryan avatar Dec 05 '22 20:12 mrseanryan

Cool

pzavolinsky avatar Dec 05 '22 20:12 pzavolinsky

closing, as it works.

we can always make more improvements later.

thank you @pzavolinsky

mrseanryan avatar Dec 05 '22 20:12 mrseanryan