pyxem icon indicating copy to clipboard operation
pyxem copied to clipboard

Deletion Candidate: Radial Utils

Open CSSFrancis opened this issue 1 year ago • 2 comments

Looking through the Radial Utils folder I think we can remove this entire folder. The beam centering based on an ellipse is useful but it would be much batter as a map like function. I have lots of code that does this so I can fairly easily add an example of this.

I would much rather have this as an example and maybe use the determine_ellipse function in ransac_ellipse tools instead. The benefit is that the ellipse is returned as an affine transformation which is more in line with the rest of pyxem.

CSSFrancis avatar Jan 29 '24 20:01 CSSFrancis

This seems sensible, but if you could hold off for a couple of days so I can have another look I would appreciate it :)

pc494 avatar Jan 29 '24 20:01 pc494

As long as it doesn't cause @magnunor problems I'm happy for these to go.

pc494 avatar Feb 06 '24 10:02 pc494

Plan is to mark these all as deprecated.

pc494 avatar Mar 31 '24 20:03 pc494