pyvistaqt icon indicating copy to clipboard operation
pyvistaqt copied to clipboard

MAINT: Add GC tests

Open larsoner opened this issue 5 years ago • 5 comments

Locally this passes. Shouldn't be merged until PyVista merges https://github.com/pyvista/pyvista/pull/958

larsoner avatar Oct 22 '20 18:10 larsoner

Codecov Report

Merging #66 (0cd0112) into main (1ad53e9) will increase coverage by 0.09%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   97.22%   97.31%   +0.09%     
==========================================
  Files           8        8              
  Lines         648      670      +22     
  Branches       81       82       +1     
==========================================
+ Hits          630      652      +22     
  Partials       18       18              

codecov[bot] avatar Oct 23 '20 11:10 codecov[bot]

Okay this is ready for review, the 3.7 Linux build correctly picks up the GC tests and they pass:

Including plotting tests (ALLOW_PLOTTING=true)
Including garbage collection tests (GC_TEST=true)

Then once pyvista/pyvista#958 is in we can merge!

larsoner avatar Oct 23 '20 12:10 larsoner

(The windows 3.6 is just a download timeout error, I don't have permissions to restart it)

larsoner avatar Oct 23 '20 12:10 larsoner

I restarted Azure but it seems like Github Actions is still not happy

GuillaumeFavelier avatar Oct 23 '20 13:10 GuillaumeFavelier

BTW @pyvista/developers can we allow @larsoner to restart the CIs?

GuillaumeFavelier avatar Oct 23 '20 14:10 GuillaumeFavelier

Okay finally green, ready for review/merge from my end @tkoyama010 !

larsoner avatar Jan 06 '23 21:01 larsoner

This is the longest I've ever seen a PR been open... and still make it to review/merge.

akaszynski avatar Jan 06 '23 21:01 akaszynski

Good idea @akaszynski, done in https://github.com/pyvista/pyvistaqt/issues/270 so I'll merge!

larsoner avatar Jan 09 '23 15:01 larsoner