pyvista icon indicating copy to clipboard operation
pyvista copied to clipboard

Add linkcheck to sphinx build

Open tkoyama010 opened this issue 2 years ago • 6 comments

Discussed in https://github.com/pyvista/pyvista/discussions/1539

Originally posted by tkoyama010 July 23, 2021 There is a option to check the integrity of all external links in sphinx-build option. This will be a good first issue in Scipy2022.

tkoyama010 avatar Aug 08 '21 03:08 tkoyama010

Hi, I'd love to contribute to the pyvista project. Would be possible to assign this issue to me? Thanks!

laysauchoa avatar Aug 01 '22 12:08 laysauchoa

@laysauchoa Thanks for contributing! We welcome your contribution.

tkoyama010 avatar Aug 01 '22 12:08 tkoyama010

Before adding this workflow, let's clarify some important points:

I can add one workflow to run for all the files in every push Advantages: catch any link that fails in every push Disadvantages: it may make things slow if you have there are too many links

OR

I can add two workflows:

  • one to run in every push only in the changed files
  • one to run weekly in the whole file

Advantages: runs faster and avoid false positive. Some pages are only temporarily unreachable. Disadvantages: maybe something fails in between and you will only catch in a week basis

ping @tkoyama010

laysauchoa avatar Aug 01 '22 13:08 laysauchoa

Nice analysis, I think it would be clearer if you measured the time with PullRequest.

tkoyama010 avatar Aug 02 '22 16:08 tkoyama010

linkcheck will take 35 min or a bit more. wdyt? I'd say that running periodically would make more sense to not have to wait for this long. However, a link could break in between.

laysauchoa avatar Aug 05 '22 21:08 laysauchoa

Might make sense to run this as a weekly cron job.

akaszynski avatar Aug 06 '22 21:08 akaszynski