safety
safety copied to clipboard
Add support for coma separated ignore (--ignore=123,456)
Fixes #341
This adds support for providing ignore as --ignore=123,456
The previous format --ignore=123 --ignore=456
is still supported for backward compatilibity, I guess you don't want to introduce a breaking change here.
Let me know if there is anything I should fix in the PR.
Codecov Report
Base: 77.21% // Head: 73.14% // Decreases project coverage by -4.07%
:warning:
Coverage data is based on head (
a89bca6
) compared to base (87000ca
). Patch coverage: 100.00% of modified lines in pull request are covered.
:exclamation: Current head a89bca6 differs from pull request most recent head 6d41bf3. Consider uploading reports for the commit 6d41bf3 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## develop #343 +/- ##
===========================================
- Coverage 77.21% 73.14% -4.07%
===========================================
Files 25 8 -17
Lines 3436 540 -2896
===========================================
- Hits 2653 395 -2258
+ Misses 783 145 -638
Impacted Files | Coverage Δ | |
---|---|---|
safety/cli.py | 68.69% <100.00%> (-18.60%) |
:arrow_down: |
safety/formatter.py | 54.38% <0.00%> (-45.62%) |
:arrow_down: |
safety/util.py | 80.39% <0.00%> (-4.10%) |
:arrow_down: |
safety/__init__.py | 100.00% <0.00%> (ø) |
|
safety/constants.py | 100.00% <0.00%> (ø) |
|
tests/test_safety.py | ||
tests/test_cli.py | ||
safety/formatters/json.py | ||
safety/alerts/utils.py | ||
... and 15 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Any update on this?
Hi, sorry to insist but is there any chance to get it merged?
Hi @bagerard, thanks for this PR! Yes, we have a coming version of Safety, I expect to merge this PR after the new 2.0 release. I'm sorry for don't reply with an update in this PR before.
Alright no problem, thanks for the feedback :+1:
Just fixed this PR, there were lots of conflict with recent changes, let me know if anything else is needed