pyup icon indicating copy to clipboard operation
pyup copied to clipboard

Stop creating a new branch each day and edit one dedicated branch.

Open DEKHTIARJonathan opened this issue 8 years ago • 5 comments

Hello dear PyUPers,

I have a few projects, which I can't update right now due to missing Django 2.0 compatible dependencies.

Which lead to the following behavior:

  • PyUP is generating everyday a new PR and close the old one.
  • PyUP creates a new branch everyday and delete the old one.

It is crazy inefficient, wouldn't it be possible to edit one single PR and push dependencies to the same branch everyday ?

Maybe I can setup pyup to behave this way, or is it something that I may be able to help to implement ?

Thanks a lot dear friends,

Jonathan

DEKHTIARJonathan avatar Dec 28 '17 12:12 DEKHTIARJonathan

This is especially important when working with PRs that can't/shouldn't be merged just yet. The comments/links that I include in the PR are essentially deleted when pyup closes the PR and opens a new one... with the same changes...

engnadeau avatar Feb 05 '18 15:02 engnadeau

That shouldn't happen. The bot will only close PRs where a newer release is available.

But I agree with the proposed changes, now to find some time to work on it 👍

jayfk avatar Feb 05 '18 16:02 jayfk

I fully agree.

For the branch:

I think the best way would be to create one-dedicated branch for pyup with a name that can be fixed in the pyup config file.

For the PR:

Then instead of creating everyday a new PR and closing the previous one. The following behavior would be, in my point of view, better:

  • if the PyUP PR is still open
    • edit the post with the text already generated when creating a new PR today.
  • else:
    • create a new PR as usual.

DEKHTIARJonathan avatar Feb 05 '18 16:02 DEKHTIARJonathan

@jayfk just a ping to have some information about this issue.

It's really annoying to have a new PR and a new branch every single day if we don't merge right away. It would be very nice if PyUP was updating the same branch over and over and only recreates it if the branch can't be merged in master automatically.

This looks ridiculous ...

image

DEKHTIARJonathan avatar Oct 11 '18 12:10 DEKHTIARJonathan

Are there any plans to provide this feature eventually? The daily PR open/close spam cycle is becoming extremely ridiculous with many repos affected by similar dependencies that cannot be updated right away. It is littering my notifications to a point that I'm considering to remove pyup entirely.

fmigneault avatar Sep 08 '21 16:09 fmigneault