Complete VIIRS_GRAN reader for NOAA CLASS - VIIRS EDR files (originally #824)

[jon4than]

All this does is fix the conflicts in #824; all credit belongs to @dhueholt.

Daniel's pull request text below:

After the Git fiasco I caused at #808 it was necessary to start from a new branch. This new branch is forked from the Pytroll Satpy master.

This pull request updates the VIIRS_GRAN reader originally created by @bbakernoaa. The reader now dynamically generates variables (based on the method in the TROPOMI reader by @tommyjasmin), requiring only the latitude/longitude to be described in YAML. The reader, formerly a copy of viirs_l1b, is changed to be fully compatible with VIIRS EDR files. All files are flake8 compatible. Appropriate unit tests are added to the test suite. These unit tests have been updated to fix (with any good luck) the issues pointed out by @djhoese in his comments on 808.

This reader works on all types of VIIRS EDR files obtainable from NOAA CLASS, except for VIIRS Active Fires which are formatted very differently. The pre-existing viirs_edr_active_fires reader is designed to deal with those.

• [ ] Closes #424, #808, and #824.
• [ ] Tests added and test suite added to parent suite
• [ ] Tests passed
• [ ] Passes flake8 satpy
• [ ] Fully documented
• [ ] Add your name to AUTHORS.md if not there already

[coveralls]

Coverage decreased (-0.04%) to 85.892% when pulling ad08d2da54b545fef86dd0e2882ba3ea04a670ae on jon4than:feature-viirs-gran into e40961ea96efa5e9a396aef8adb644789ae647e1 on pytroll:master.

[djhoese]

Thanks @jon4than. One of the travis OSX jobs failed for unrelated reasons. I restarted it so hopefully it should complete.

[codecov[bot]]

Codecov Report

Merging #951 into master will decrease coverage by 0.03%. The diff coverage is 82.12%.

@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   85.92%   85.89%   -0.04%     
==========================================
  Files         174      176       +2     
  Lines       26452    26687     +235     
==========================================
+ Hits        22730    22923     +193     
- Misses       3722     3764      +42

Impacted Files	Coverage Δ
satpy/tests/reader_tests/__init__.py	98.24% <100%> (+0.03%)	:arrow_up:
satpy/readers/viirs_edr_gran.py	70.99% <70.99%> (ø)
satpy/tests/reader_tests/test_viirs_edr_gran.py	96.11% <96.11%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e40961e...ad08d2d. Read the comment docs.

[tommyjasmin]

Thanks for implementing this new reader! I just have one concern about the test coverage, it seems like you are not testing the radiance and reflectance products. It would increase the coverage a bit if you did that. See here https://codecov.io/gh/pytroll/satpy/pull/951/diff?src=pr&el=tree#diff-c2F0cHkvcmVhZGVycy92aWlyc19lZHJfZ3Jhbi5weQ==

Sure Martin - we can beef up the tests a bit. Stay tuned...

[mraspaud]

@tommyjasmin @jon4than any news on this ?

[tommyjasmin]

@tommyjasmin @jon4than any news on this ?

Hi Martin - sorry we haven't gotten to this yet. We are currently not allowed in the office and have had some other recent work disruptions. We haven't forgotten and will try to get this addressed soon...

[djhoese]

@jon4than @tommyjasmin Any available time to work on this?

[tommyjasmin]

Hey guys, I will talk to Jon and see if we can't take a look at this next week.