Implement band and metadata file handlers for landsat 8 data
Reader for landsat 8 data
-
[ ] Finish converting yaml file from MSI to OLI/TIRS
-
[ ] Factorize metadata reading with MODIS readers
-
[ ] Quality flags
-
[ ] Angles
-
[ ] Tests
-
[ ] DataArrays' attributes
-
[ ] Read directly from tar file
-
[ ] Add reader to reader list
-
[ ] Closes #xxxx
-
[ ] Tests added and test suite added to parent suite
-
[ ] Tests passed
-
[x] Passes
flake8 satpy -
[ ] Fully documented
Coverage decreased (-0.5%) to 83.625% when pulling a91a88f6440142b1319d790f88d96068cc4b2dc9 on mraspaud:feature-l8 into cc6ba42c08a77c46205c0d8ac6008ea5e6ba8cbd on pytroll:master.
Thing is I don't know how we would do composites with channels from both instruments...
I mean it would work, but would require someone to do scn = Scene(reader=['tirs_l1', 'oli_l1'], filenames=filenames) which is probably needlessly confusing. But is consistency more important that UX?
What about the full name of the satellite versus the abbreviation? Thoughts?
we could make a oli/tirs instrument...
about the name, I just wrote whatever came through my head at the time, no strong opinions at all. This was put up very quickly yesterday, there is surely a lot to be improved.
Codecov Report
Merging #862 (a91a88f) into main (0c2b965) will decrease coverage by
10.57%. The diff coverage is16.07%.
:exclamation: Current head a91a88f differs from pull request most recent head 45f053c. Consider uploading reports for the commit 45f053c to get more accurate results
@@ Coverage Diff @@
## main #862 +/- ##
===========================================
- Coverage 94.19% 83.62% -10.58%
===========================================
Files 295 168 -127
Lines 45393 24709 -20684
===========================================
- Hits 42760 20664 -22096
- Misses 2633 4045 +1412
| Flag | Coverage Δ | |
|---|---|---|
| behaviourtests | ? |
|
| unittests | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| satpy/readers/lsa8_l1.py | 16.07% <16.07%> (ø) |
|
| satpy/tests/reader_tests/test_eum_base.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| satpy/readers/hrpt.py | 3.90% <0.00%> (-94.75%) |
:arrow_down: |
| satpy/readers/msi_safe.py | 2.52% <0.00%> (-91.08%) |
:arrow_down: |
| satpy/readers/sar_c_safe.py | 19.45% <0.00%> (-77.82%) |
:arrow_down: |
| satpy/readers/aapp_l1b.py | 13.65% <0.00%> (-76.04%) |
:arrow_down: |
| satpy/readers/xmlformat.py | 17.24% <0.00%> (-72.51%) |
:arrow_down: |
| satpy/readers/eum_base.py | 18.18% <0.00%> (-71.62%) |
:arrow_down: |
| satpy/readers/eps_l1b.py | 15.85% <0.00%> (-67.77%) |
:arrow_down: |
| satpy/composites/sar.py | 0.00% <0.00%> (-67.22%) |
:arrow_down: |
| ... and 296 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@mraspaud what is your interest in continuing this reader? I had someone ask me about landsat support in Satpy last week and I remembered you had this PR started. Is the data being read here what most people think of when they say landsat?
I have the same question. I've tried starting a reader myself then gave up. lol