satpy icon indicating copy to clipboard operation
satpy copied to clipboard

support bz2 compression in avhrr_l1b_eps

Open k3a opened this issue 1 year ago • 3 comments

EUMETCast distributes global METOP AVHRR data bz2-compressed (example AVHR_xxx_1B_M01_20241113130103Z_20241113130403Z_N_O_20241113133530Z.bz2).

This commit adds decompression support by reusing already-tested unzip_context helper function.

k3a avatar Nov 13 '24 19:11 k3a

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.17%. Comparing base (fd2cec6) to head (81daacd). Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2978      +/-   ##
==========================================
+ Coverage   96.10%   96.17%   +0.07%     
==========================================
  Files         377      374       -3     
  Lines       55147    54977     -170     
==========================================
- Hits        52997    52873     -124     
+ Misses       2150     2104      -46     
Flag Coverage Δ
behaviourtests ?
unittests 96.17% <100.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 13 '24 19:11 codecov[bot]

Pull Request Test Coverage Report for Build 11824388461

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.207%

Totals Coverage Status
Change from base Build 11815057382: 0.0%
Covered Lines: 53244
Relevant Lines: 55343

💛 - Coveralls

coveralls avatar Nov 13 '24 19:11 coveralls

Hello @mraspaud , as I was involved in the unzip context I though of giving this PR a boost.

But the tests are not file-based. I propose to convert the test file to not use mocks anymore. But I can't make sense of the test test_get_full_angles_twice...

Also, the failing tests seem to rely on parsing the log of satpy and checking for the appearance of "WARNING" in there. Probably, this PR (here, #2978) can't proceed before the tests are completely updated.

pdebuyl avatar Apr 29 '25 07:04 pdebuyl