add support of masking olci l1b products by using quality flags
This PR added support of using the quality flags from the qualityFlags.nc file to mask the OCLI L1b products, similar as using wqsf file masking OLCI L2 products.
- [x] Closes #1209
- [x] Tests added
- [ ] Fully documented
Codecov Report
Attention: Patch coverage is 98.68421% with 1 line in your changes missing coverage. Please review.
Project coverage is 95.98%. Comparing base (
f9dba55) to head (5e19113). Report is 59 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| satpy/readers/olci_nc.py | 96.96% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2687 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 368 368
Lines 53798 53852 +54
=======================================
+ Hits 51639 51692 +53
- Misses 2159 2160 +1
| Flag | Coverage Δ | |
|---|---|---|
| behaviourtests | 4.03% <0.00%> (-0.01%) |
:arrow_down: |
| unittests | 96.08% <98.68%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pull Request Test Coverage Report for Build 7212041175
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.
- 71 of 73 (97.26%) changed or added relevant lines in 2 files are covered.
- 49 unchanged lines in 3 files lost coverage.
- Overall coverage increased (+0.03%) to 95.915%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| satpy/readers/olci_nc.py | 32 | 34 | 94.12% |
| <!-- | Total: | 71 | 73 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| satpy/tests/test_resample.py | 2 | 99.57% |
| satpy/composites/init.py | 4 | 93.07% |
| satpy/resample.py | 43 | 88.74% |
| <!-- | Total: | 49 |
| Totals | |
|---|---|
| Change from base Build 7188190011: | 0.03% |
| Covered Lines: | 50128 |
| Relevant Lines: | 52263 |
💛 - Coveralls
I don't know enough about this reader to have the final say, I think @mraspaud should do that. This looks good enough to me though.
Thanks Dave.
Pull Request Test Coverage Report for Build 10107490696
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 75 of 76 (98.68%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall first build on olci_l1b_quality_flags at 96.088%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| satpy/readers/olci_nc.py | 32 | 33 | 96.97% |
| <!-- | Total: | 75 | 76 |
| Totals | |
|---|---|
| Change from base Build 10107440456: | 96.1% |
| Covered Lines: | 51921 |
| Relevant Lines: | 54035 |