satpy icon indicating copy to clipboard operation
satpy copied to clipboard

Detect Navigation Type of geocat file

Open joleenf opened this issue 2 years ago • 2 comments

This pull request adds checks for global attributes in the geocat file to determine if the navigation has been terrain corrected. If it has, a SwathDefinition is used to facilitate the irregular grid of coordinates.

The yaml was also updated to separate level1 from level2 file_types.

A check for projection_longitude was also added since this appears to be in the global attributes now.

  • [ ] Closes #2512
  • [ ] Tests added to check if the terrain corrected property is set to true when there is indication of terrain correction in the global attributes

joleenf avatar Jul 28 '23 23:07 joleenf

Codecov Report

Merging #2536 (4bb2d70) into main (f74d4d6) will decrease coverage by 0.01%. Report is 270 commits behind head on main. The diff coverage is 93.12%.

:exclamation: Current head 4bb2d70 differs from pull request most recent head 3237a58. Consider uploading reports for the commit 3237a58 to get more accurate results

@@            Coverage Diff             @@
##             main    #2536      +/-   ##
==========================================
- Coverage   94.87%   94.86%   -0.01%     
==========================================
  Files         349      349              
  Lines       50855    50950      +95     
==========================================
+ Hits        48248    48336      +88     
- Misses       2607     2614       +7     
Flag Coverage Δ
behaviourtests 4.31% <0.00%> (-0.01%) :arrow_down:
unittests 95.47% <93.12%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
satpy/tests/reader_tests/test_geocat.py 100.00% <100.00%> (ø)
satpy/readers/geocat.py 88.37% <85.93%> (-0.45%) :arrow_down:

codecov[bot] avatar Jul 29 '23 00:07 codecov[bot]

Pull Request Test Coverage Report for Build 5824951395

  • 122 of 131 (93.13%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.03%) to 95.423%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/readers/geocat.py 55 64 85.94%
<!-- Total: 122 131
Files with Coverage Reduction New Missed Lines %
satpy/readers/geocat.py 1 88.37%
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 3 98.67%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 3 97.16%
satpy/tests/reader_tests/utils.py 5 84.85%
<!-- Total: 12
Totals Coverage Status
Change from base Build 5786388105: -0.03%
Covered Lines: 48449
Relevant Lines: 50773

💛 - Coveralls

coveralls avatar Jul 29 '23 00:07 coveralls