pytroll
Fixes for PR#2146 so readers now also work for VII L2 water vapour pr…
…oducts
This PR fixes vii_base_nc.py so VII L2 WV products can be read and concatenated (fix include variables num_points_act, num_points_alt for the renaming to Y,X in _standardise_dims). Additionally a missing comma in the tpw product in vii_l2_nc.yaml is corrected and a redundant comma removed.
Codecov Report
Merging #2201 (212ea44) into main (5ec31cf) will decrease coverage by
0.00%. The diff coverage is91.42%.
@@ Coverage Diff @@
## main #2201 +/- ##
==========================================
- Coverage 94.37% 94.37% -0.01%
==========================================
Files 310 311 +1
Lines 46665 46700 +35
==========================================
+ Hits 44040 44072 +32
- Misses 2625 2628 +3
| Flag | Coverage Δ | |
|---|---|---|
| behaviourtests | 4.58% <0.00%> (-0.01%) |
:arrow_down: |
| unittests | 95.01% <91.42%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| satpy/readers/vii_base_nc.py | 93.63% <50.00%> (-0.81%) |
:arrow_down: |
| satpy/tests/reader_tests/test_vii_wv_nc.py | 93.93% <93.93%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Coverage decreased (-0.003%) to 94.962% when pulling 212ea443e3a19eb0a58ae18a697c440f2018e10f on pepephillips:L2_dev into 5ec31cf80681205cac2949163c18678dd9e958d3 on pytroll:main.
@pepephillips Any chance of getting small test for the dimension rename? :)
Hi Martin, Sorry for the unthinkably long delay but I have a small test. Shall I put in a PR for it or is it too late?
I’ve also been working on readers for CO2M missions CLIM (a simpler version of METimage) and MAP (3MI-like). MAP is so similar to 3MI its almost a cut and paste job to get something up and running. Have you already started on 3MI? Cheers, Pepe
From: Martin Raspaud @.> Sent: Wednesday 9 November 2022 15:58 To: pytroll/satpy @.> Cc: Pepe Phillips @.>; Mention @.> Subject: Re: [pytroll/satpy] Fixes for PR#2146 so readers now also work for VII L2 water vapour pr… (PR #2201)
WARNING: This email originated outside the organisation. Treat links and attachments with caution.
@pepephillipshttps://github.com/pepephillips Any chance of getting small test for the dimension rename? :)
— Reply to this email directly, view it on GitHubhttps://github.com/pytroll/satpy/pull/2201#issuecomment-1308890005, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP77JH6GWQBFLXUKR6HYTPDWHO3YLANCNFSM6AAAAAAQHXXPUQ. You are receiving this because you were mentioned.Message ID: @.***>
Any email message from EUMETSAT is sent in good faith but shall neither be binding nor construed as constituting a commitment by EUMETSAT, except where provided for in a written agreement or contract or if explicitly stated in the email. Please note that any views or opinions presented in this email are solely those of the sender and do not necessarily represent those of EUMETSAT. This message and any attachments are intended for the sole use of the addressee(s) and may contain confidential and privileged information. Any unauthorised use, disclosure, dissemination or distribution (in whole or in part) of its contents is not permitted. If you received this message in error, please notify the sender and delete it from your system.