satpy icon indicating copy to clipboard operation
satpy copied to clipboard

Fix coordinate names in Ocean Color CCI reader.

Open simonrp84 opened this issue 3 years ago • 1 comments

I mistakenly forgot to set the correct coordinate names in the Ocean Color CCI reader. Satpy expects x and y but I was using lon and lat.

This PR renames the coordinates within the reader and also fixes the tests so that they use the same coordinate names as the actual data files.

simonrp84 avatar Aug 06 '22 07:08 simonrp84

Codecov Report

Merging #2168 (b9d77a6) into main (7704146) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2168      +/-   ##
==========================================
- Coverage   94.81%   94.81%   -0.01%     
==========================================
  Files         339      339              
  Lines       49356    49366      +10     
==========================================
+ Hits        46798    46807       +9     
- Misses       2558     2559       +1     
Flag Coverage Δ
behaviourtests 4.42% <0.00%> (-0.01%) :arrow_down:
unittests 95.43% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/oceancolorcci_l3_nc.py 100.00% <100.00%> (ø)
...tpy/tests/reader_tests/test_oceancolorcci_l3_nc.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 06 '22 07:08 codecov[bot]

@djhoese Just coming back to this, how do you mean "a check the dimensions are correct"? You mean the dimension names or the actual dimensions (shape) of the arrays?

simonrp84 avatar Nov 09 '22 09:11 simonrp84

Dimension names. You made sure that the fake input data now looks like the real data, but do you have a check on the loaded DataArray that it has the right dimensions?

djhoese avatar Nov 09 '22 14:11 djhoese

@simonrp84 any reply to the last comment?

mraspaud avatar Mar 14 '23 13:03 mraspaud

Forgot about this, will take a look in the next few days.

simonrp84 avatar Apr 17 '23 10:04 simonrp84

Coverage Status

Coverage: 95.385% (+0.0009%) from 95.384% when pulling b9d77a697a21f09c90eec5f166e3343e8223ceb3 on simonrp84:oc_cci_fix into 7704146f7eeff54411f152b967b1646d76299889 on pytroll:main.

coveralls avatar Apr 17 '23 11:04 coveralls

@simonrp84 any news?

mraspaud avatar Apr 21 '23 08:04 mraspaud

@mraspaud Hopefully the extra test I just added will address the issue raised by @djhoese

simonrp84 avatar Apr 23 '23 11:04 simonrp84

pre-commit.ci autofix

simonrp84 avatar Apr 23 '23 11:04 simonrp84