satpy icon indicating copy to clipboard operation
satpy copied to clipboard

Use different names for substantially different RGBs / rename viirs night_microphysics composite

Open gerritholl opened this issue 3 years ago • 3 comments
trafficstars

Feature Request

Is your feature request related to a problem? Please describe.

Some widely different RGBs share the same name.

night_microphysics in visir.yaml has:

  • Red: BT(12.0 µm) - BT(10.8 µm)
  • Green: BT(10.8 µm) - BT(3.9 µm)
  • Blue: BT(10.8 µm)

https://github.com/pytroll/satpy/blob/bbb93b36023c50c9d91c5dedd0b5f67a3cdef4f7/satpy/etc/composites/visir.yaml#L379-L391

night_microphysics in viirs.yaml has:

  • Red: DNB (0.7 µm)
  • Green: M12 (3.7 µm)
  • Blue: M15 (10.8 µm)

https://github.com/pytroll/satpy/blob/bbb93b36023c50c9d91c5dedd0b5f67a3cdef4f7/satpy/etc/composites/viirs.yaml#L355-L361

The definition is very different, but the name is the same. This is confusing.

Describe the solution you'd like

I want that composites should have the same name only if they are the same or very similar.

I would like that the VIIRS night_microphysics RGB is renamed.

Describe any changes to existing user workflow

Any code using the VIIRS night_microphysics will break.

Following #1660, any code using the VIIRS night_microphysics RGB is already broken.

Therefore, no functioning code will break following this change.

Additional context

See #1660. Not only is the VIIRS night_microphysics claiming a name that already exists, it is also kaputt.

gerritholl avatar Jan 10 '22 17:01 gerritholl

It looks like @mraspaud made the original composite and then later on @adybbroe changed DNB to hncc_dnb. Do you two have any ideas where this recipe came from?

djhoese avatar Jan 10 '22 18:01 djhoese

@adybbroe made the viirs recipe, it's an experimental composite, but happens to have the same name as another one. I guess we should rename the viirs one.

mraspaud avatar Jan 11 '22 16:01 mraspaud