Refactor utils module
This PR refactors the pyspectral.utils module.
- [ ] Closes #xxxx
- [ ] Tests added
- [ ] Tests passed: Passes
pytest pyspectral - [ ] Passes
flake8 pyspectral - [ ] Fully documented
- [ ] Add your name to
AUTHORS.mdif not there already
Codecov Report
:x: Patch coverage is 93.39623% with 7 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 90.35%. Comparing base (d4ea15a) to head (c2fe336).
:warning: Report is 3 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pyspectral/utils.py | 93.39% | 7 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 90.28% 90.35% +0.06%
==========================================
Files 22 22
Lines 2523 2541 +18
==========================================
+ Hits 2278 2296 +18
Misses 245 245
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 90.35% <93.39%> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Very nice work @pnuu , thanks! Do we have test coverage of all this? Or do you want/need help there?
Codecov shows that the code in the if isinstance(det_rsr[key], dict) branch moved to the new _collect_responses(det_rsr, key, det_wavenumbers) function isn't covered. The other part is the untouched logger setup. If you have ideas how to test the former, please do :+1: