pygac icon indicating copy to clipboard operation
pygac copied to clipboard

Avoid implicit changes to ict and space counts in thermal calibration

Open carloshorn opened this issue 4 years ago • 2 comments

To avoid an implicit change of the input arrays, I would move the interpolation of missing/wrong data in the ICT and space counts to the POD/KLM specific reader method get_telemetry or use a copy instead of changing the input in-place.

https://github.com/pytroll/pygac/blob/8a7f11edac14e44f3caf8d6f23cf095ff77ec17e/pygac/calibration.py#L409-L425

carloshorn avatar Aug 14 '20 13:08 carloshorn

I like the idea to move this to the POD/KLM specific get_telemetry methods. There are probably a number of methods in pygac which change data in-place and would need a refactoring. This one's a good start!

sfinkens avatar Aug 21 '20 08:08 sfinkens

Sounds good, go ahead!

mraspaud avatar Aug 21 '20 12:08 mraspaud