DAWG icon indicating copy to clipboard operation
DAWG copied to clipboard

Fix various cython related compile errors

Open poke1024 opened this issue 5 years ago • 8 comments

Should fix https://github.com/pytries/DAWG/issues/35, https://github.com/pytries/DAWG/issues/34, https://github.com/pytries/DAWG/issues/31.

Tested with python 3.7.3 (macOS) and python 2.7.10 (macOS).

With latest Python 3 things compile without warnings (see the four included int casts in ranged for loops).

poke1024 avatar Apr 21 '19 11:04 poke1024

Travis fails due to not having cython installed.

poke1024 avatar Apr 21 '19 11:04 poke1024

Fixed Travis: removed support for Python 3.2, added Python 3.5 and Python 3.6. Python 3.7 is not yet supported by Travis out of the box.

poke1024 avatar Apr 22 '19 03:04 poke1024

Why is this not merged?

dbuscaglia avatar Oct 09 '19 15:10 dbuscaglia

No issues so far with Python 3.7.4 on win10 using IntDAWG

markanewman avatar Oct 11 '19 09:10 markanewman

This PR should be merged as the referenced issues are still happening :

  • MacOS High Sierra 10.13.6
  • Python 3
  • Anaconda 3
Command "/anaconda3/bin/python -u -c "import setuptools, tokenize;__file__='/private/var/folders/9v/XXXXXXX/T/pip-install-jf78ea1b/DAWG/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /private/var/folders/9v/XXXXXXX0000gp/T/pip-record-adzwmina/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /private/var/folders/9v/XXXXXXX2pjth0000gp/T/pip-install-jf78ea1b/DAWG/

hzitoun avatar Oct 21 '19 09:10 hzitoun

@hzitoun could you please try installing from github? I've updated DAWG to support recent Pythons, but haven't made a release yet.

kmike avatar Oct 21 '19 10:10 kmike

@kmike I'm trying. I'll keep you informed/

hzitoun avatar Oct 21 '19 16:10 hzitoun

So after updating everything (conda update --all), installing from github works! so thanks

hzitoun avatar Oct 21 '19 16:10 hzitoun