xla icon indicating copy to clipboard operation
xla copied to clipboard
verified publisher icon pytorch

EmbeddingDenseBackward: Remove `padding_idx` cast to `double`

Open unterumarmung opened this issue 6 months ago • 1 comments

Fixes #9392

unterumarmung avatar Jun 25 '25 11:06 unterumarmung

Thanks for the change! I am going to run the CI and see if it breaks anything

bhavya01 avatar Jun 25 '25 16:06 bhavya01

Can you also please add a test for embedding backward similar to this one https://github.com/pytorch/xla/blob/193f7049ef56639122b11c03add44512aee9f66a/test/test_operations.py#L738

bhavya01 avatar Jun 25 '25 21:06 bhavya01

Done.

Please, rerun the CI

unterumarmung avatar Jun 26 '25 21:06 unterumarmung

Seems like everything has passed. The failing job is broken in master, if I understand correctly.

unterumarmung avatar Jun 27 '25 20:06 unterumarmung

The E2E tests have been failing for some time

bhavya01 avatar Jul 07 '25 16:07 bhavya01