xla icon indicating copy to clipboard operation
xla copied to clipboard

Add dynamo `torch.Tensor.new` test.

Open ysiraichi opened this issue 11 months ago • 1 comments

This PR adds a test for #6009. The actual fix is implemented in the PyTorch main repository: https://github.com/pytorch/pytorch/pull/121075

@miladm @JackCaoG

ysiraichi avatar Mar 02 '24 15:03 ysiraichi

This PR should only be merged after:

  • [x] https://github.com/pytorch/pytorch/pull/121075
  • [ ] ~https://github.com/pytorch/xla/pull/6659~

ysiraichi avatar Mar 02 '24 15:03 ysiraichi

I'm moving this one forward, since #6659 will take some time to get merged.

ysiraichi avatar Apr 03 '24 15:04 ysiraichi

@JackCaoG Could you take a look at it whenever you have some time?

ysiraichi avatar Apr 03 '24 15:04 ysiraichi

change lgtm but somehow CI doesn't get trigger. Can you do another push to the branch to see if it will trigger the CI? Otherwise start a new pr might be better.

JackCaoG avatar Apr 03 '24 18:04 JackCaoG

@JackCaoG Is this ok to land? All the CI test are passing, now.

ysiraichi avatar Apr 07 '24 17:04 ysiraichi