xla icon indicating copy to clipboard operation
xla copied to clipboard
verified publisher icon pytorch

Lower op embedding bag

Open bhavya01 opened this issue 1 year ago • 2 comments

bhavya01 avatar Feb 21 '24 01:02 bhavya01

@wonjoolee95 This should be ready for review. I implemented the _embedding_bag_forward_only op for now. It seems that a lot of tests fail without the backward pass implementation.

bhavya01 avatar Feb 27 '24 18:02 bhavya01

Thanks! I'll take a look at this today.

wonjoo-wj avatar Feb 29 '24 18:02 wonjoo-wj

@wonjoolee95 Do you think that you have time to look at this PR?

bhavya01 avatar Apr 17 '24 01:04 bhavya01

Apologies for missing this PR. Changes LGTM, thanks!

I noticed an unrelated commit [Update infra_triggers.tf](https://github.com/pytorch/xla/pull/6574/commits/6dccf0a02d7828516bdb589f2ae0dc79b64488fa), can you fix the rebase?

wonjoo-wj avatar Apr 17 '24 18:04 wonjoo-wj