xla icon indicating copy to clipboard operation
xla copied to clipboard

Enable torchvision

Open ManfeiBai opened this issue 1 year ago • 4 comments

ManfeiBai avatar Feb 01 '24 02:02 ManfeiBai

I think this is also going to overwrite the pytorch build in our nightly images, which is not what we want.

Yeah, that's great point! Perhaps we make the similar change in the release branch as r2.3, for example, so we get the correct torch package. [Edit]: If the master branch code is used to create nightly image, perhaps we can install the official nightly wheels for example pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cu121

vanbasten23 avatar Feb 01 '24 23:02 vanbasten23

we met the error RuntimeError: operator torchvision::nms does not exist in TPU CI too: https://github.com/pytorch/xla/runs/21133256024

ManfeiBai avatar Feb 02 '24 06:02 ManfeiBai

TPU CI met the same error, so it happen on master branch too, the reason of this error looks like other tests use PyTorch/XLA built torchvision: https://github.com/pytorch/xla/actions/runs/7762948294/job/21175714067?pr=6439#logs, not the offical. torchvision wheel

we might want to modify to install torchvision in TPUCI too: pip_install --user --no-use-pep517 "git+https://github.com/pytorch/vision.git@$TORCHVISION_COMMIT"

same like this idea, we need to use torch/torchvision from source or built&then&use?

ManfeiBai avatar Feb 03 '24 07:02 ManfeiBai

since https://github.com/pytorch/xla/pull/6458 merged, close this PR

ManfeiBai avatar Feb 07 '24 00:02 ManfeiBai